Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: test crypto.setEngine() using an actual engine #40481

Conversation

RaisinTen
Copy link
Contributor

Signed-off-by: Darshan Sen [email protected]

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Oct 16, 2021
@RaisinTen RaisinTen force-pushed the test/test-crypto.setEngine()-using-an-actual-engine branch 8 times, most recently from b5b6031 to 06d723d Compare October 16, 2021 16:10
@RaisinTen
Copy link
Contributor Author

cc @nodejs/crypto @nodejs/build

node.gyp Outdated Show resolved Hide resolved
@RaisinTen RaisinTen force-pushed the test/test-crypto.setEngine()-using-an-actual-engine branch 3 times, most recently from 7f3bc48 to 6fb45e4 Compare October 17, 2021 14:13
@RaisinTen RaisinTen added the wip Issues and PRs that are still a work in progress. label Oct 17, 2021
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@RaisinTen RaisinTen force-pushed the test/test-crypto.setEngine()-using-an-actual-engine branch 3 times, most recently from 5c70bd4 to fb5cead Compare October 23, 2021 14:41
@nodejs-github-bot

This comment has been minimized.

@RaisinTen RaisinTen removed wip Issues and PRs that are still a work in progress. needs-ci PRs that need a full CI run. labels Oct 24, 2021
@RaisinTen RaisinTen force-pushed the test/test-crypto.setEngine()-using-an-actual-engine branch from 46699f9 to 157eeca Compare October 24, 2021 05:24
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot
Copy link
Collaborator

@Mesteery Mesteery added the test Issues and PRs related to the tests. label Oct 25, 2021
@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 25, 2021
@RaisinTen RaisinTen requested a review from addaleax October 25, 2021 15:36
@RaisinTen RaisinTen added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 30, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 30, 2021
@github-actions
Copy link
Contributor

Landed in babd73c...ff536fa

@github-actions github-actions bot closed this Oct 30, 2021
nodejs-github-bot pushed a commit that referenced this pull request Oct 30, 2021
Signed-off-by: Darshan Sen <[email protected]>

PR-URL: #40481
Reviewed-By: James M Snell <[email protected]>
@RaisinTen RaisinTen deleted the test/test-crypto.setEngine()-using-an-actual-engine branch October 30, 2021 08:59
targos pushed a commit that referenced this pull request Nov 6, 2021

Verified

This commit was signed with the committer’s verified signature.
targos Michaël Zasso
Signed-off-by: Darshan Sen <[email protected]>

PR-URL: #40481
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Nov 8, 2021
BethGriggs pushed a commit that referenced this pull request Nov 25, 2021

Verified

This commit was signed with the committer’s verified signature.
BethGriggs Bethany Griggs
Signed-off-by: Darshan Sen <[email protected]>

PR-URL: #40481
Reviewed-By: James M Snell <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Nov 26, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants