-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: update lint-md dependencies #40404
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update lint-md dependencies and re-create lint-md.mjs.
targos
approved these changes
Oct 11, 2021
Trott
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Oct 11, 2021
Lxxyx
approved these changes
Oct 11, 2021
aduh95
approved these changes
Oct 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still have CJS dependencies?
So none of our direct dependencies are CJS, but some of our sub-dependencies are, so we still need the rollup plugin. |
Trott
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Oct 13, 2021
github-actions
bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Oct 13, 2021
Landed in 983b757...350a95b |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Oct 13, 2021
Update lint-md dependencies and re-create lint-md.mjs. PR-URL: #40404 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
2 tasks
targos
pushed a commit
that referenced
this pull request
Nov 4, 2021
Update lint-md dependencies and re-create lint-md.mjs. PR-URL: #40404 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
tools
Issues and PRs related to the tools directory.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update lint-md dependencies and re-create lint-md.mjs.