-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: update fast-track approval comment request #40316
Closed
VoltrexKeyva
wants to merge
1
commit into
nodejs:master
from
VoltrexKeyva:update-fast-track-comment-request
Closed
doc: update fast-track approval comment request #40316
VoltrexKeyva
wants to merge
1
commit into
nodejs:master
from
VoltrexKeyva:update-fast-track-comment-request
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mesteery
reviewed
Oct 4, 2021
Collaborators no longer need to add a comment for other collaborators to upvote after adding the `fast-track` label as the GitHub actions bot is configured to automatically add a comment after the label is added.
VoltrexKeyva
force-pushed
the
update-fast-track-comment-request
branch
from
October 4, 2021 17:28
b28568b
to
c4053ec
Compare
lpinca
approved these changes
Oct 4, 2021
mhdawson
approved these changes
Oct 4, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Flarna
approved these changes
Oct 4, 2021
benjamingr
approved these changes
Oct 4, 2021
Trott
approved these changes
Oct 5, 2021
Fast-track has been requested by @Trott. Please 👍 to approve. |
gireeshpunathil
approved these changes
Oct 5, 2021
Trott
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Oct 5, 2021
github-actions
bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Oct 5, 2021
Landed in 658612b...8fc4169 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Oct 5, 2021
Collaborators no longer need to add a comment for other collaborators to upvote after adding the `fast-track` label as the GitHub actions bot is configured to automatically add a comment after the label is added. PR-URL: #40316 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Oct 5, 2021
Collaborators no longer need to add a comment for other collaborators to upvote after adding the `fast-track` label as the GitHub actions bot is configured to automatically add a comment after the label is added. PR-URL: #40316 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
doc
Issues and PRs related to the documentations.
fast-track
PRs that do not need to wait for 48 hours to land.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collaborators no longer need to add a comment for other collaborators to upvote after adding the
fast-track
label as the GitHub Actions is configured to automatically add a comment after the label is added.