Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update fast-track approval comment request #40316

Conversation

VoltrexKeyva
Copy link
Member

@VoltrexKeyva VoltrexKeyva commented Oct 4, 2021

Collaborators no longer need to add a comment for other collaborators to upvote after adding the fast-track label as the GitHub Actions is configured to automatically add a comment after the label is added.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 4, 2021
Collaborators no longer need to add a comment for other collaborators
to upvote after adding the `fast-track` label as the GitHub actions
bot is configured to automatically add a comment after the label is
added.
@VoltrexKeyva VoltrexKeyva force-pushed the update-fast-track-comment-request branch from b28568b to c4053ec Compare October 4, 2021 17:28
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 5, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2021

Fast-track has been requested by @Trott. Please 👍 to approve.

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 5, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 5, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2021

Landed in 658612b...8fc4169

@github-actions github-actions bot closed this Oct 5, 2021
nodejs-github-bot pushed a commit that referenced this pull request Oct 5, 2021
Collaborators no longer need to add a comment for other collaborators
to upvote after adding the `fast-track` label as the GitHub actions
bot is configured to automatically add a comment after the label is
added.

PR-URL: #40316
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@VoltrexKeyva VoltrexKeyva deleted the update-fast-track-comment-request branch October 5, 2021 07:06
danielleadams pushed a commit that referenced this pull request Oct 5, 2021
Collaborators no longer need to add a comment for other collaborators
to upvote after adding the `fast-track` label as the GitHub actions
bot is configured to automatically add a comment after the label is
added.

PR-URL: #40316
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants