Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: fix find-inactive-collaborators for recent README change #40163

Closed
wants to merge 1 commit into from
Closed

tools: fix find-inactive-collaborators for recent README change #40163

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Sep 20, 2021

I missed this change in 420cdc7.

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Sep 20, 2021
mhdawson
mhdawson approved these changes Sep 20, 2021
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 21, 2021
@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 22, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 22, 2021
@github-actions
Copy link
Contributor

Landed in 8d5675e...24cc239

@github-actions github-actions bot closed this Sep 22, 2021
nodejs-github-bot pushed a commit that referenced this pull request Sep 22, 2021
@Trott @nodejs-github-bot
tools: fix find-inactive-collaborators for recent README change
24cc239 
I missed this change in 420cdc7.

PR-URL: #40163
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Oct 4, 2021
@Trott @targos
tools: fix find-inactive-collaborators for recent README change
80fdedd 
I missed this change in 420cdc7.

PR-URL: #40163
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@danielleadams danielleadams mentioned this pull request Oct 4, 2021
Merged
@Trott Trott deleted the quick-fix branch September 25, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Trott @lpinca @targos @BethGriggs @mhdawson @nodejs-github-bot