-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crypto: fix webcrypto Curve25519 and Curve448 spki/pkcs8 imports #40131
Closed
+41
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
approved these changes
Sep 16, 2021
panva
force-pushed
the
fix-ed-der-import
branch
from
September 16, 2021 20:18
314cd80
to
fd5656a
Compare
panva
force-pushed
the
fix-ed-der-import
branch
from
September 16, 2021 20:21
fd5656a
to
57246bf
Compare
panva
force-pushed
the
fix-ed-der-import
branch
from
September 16, 2021 21:01
57246bf
to
b2c014e
Compare
panva
added
request-ci
Add this label to start a Jenkins CI on a PR.
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
and removed
needs-ci
PRs that need a full CI run.
labels
Sep 16, 2021
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Sep 16, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
cc @nodejs/crypto |
18 tasks
tniessen
reviewed
Sep 17, 2021
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Sep 17, 2021
This comment has been minimized.
This comment has been minimized.
tniessen
approved these changes
Sep 17, 2021
This was referenced Sep 18, 2021
panva
added a commit
that referenced
this pull request
Sep 20, 2021
PR-URL: #40131 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Landed in 453bb6b |
BethGriggs
pushed a commit
that referenced
this pull request
Sep 21, 2021
PR-URL: #40131 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Sep 21, 2021
PR-URL: #40131 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
This was referenced Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
crypto
Issues and PRs related to the crypto subsystem.
webcrypto
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following webcrypto key algorithm' SPKI and PKCS8 imports