Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update all dependencies of markdown linter #40035

Closed
wants to merge 1 commit into from
Closed

tools: update all dependencies of markdown linter #40035

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Sep 8, 2021

No description provided.

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Sep 8, 2021
lpinca
lpinca reviewed Sep 8, 2021
View reviewed changes
Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@targos targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 9, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 9, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2021

Commit Queue failed
- Loading data for nodejs/node/pull/40035
✔  Done loading data for nodejs/node/pull/40035
----------------------------------- PR info ------------------------------------
Title      tools: update all dependencies of markdown linter (#40035)
Author     Michaël Zasso  (@targos)
Branch     targos:update-lint-md -> nodejs:master
Labels     tools
Commits    1
 - tools: update all dependencies of markdown linter
Committers 1
 - Michaël Zasso 
PR-URL: https://github.com/nodejs/node/pull/40035
Reviewed-By: Antoine du Hamel 
Reviewed-By: Tobias Nießen 
Reviewed-By: James M Snell 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/40035
Reviewed-By: Antoine du Hamel 
Reviewed-By: Tobias Nießen 
Reviewed-By: James M Snell 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 08 Sep 2021 09:28:13 GMT
   ✔  Approvals: 4
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/40035#pullrequestreview-748938101
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/40035#pullrequestreview-749145920
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/40035#pullrequestreview-749364257
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/40035#pullrequestreview-750717020
   ✖  This PR needs to wait 10 more hours to land
   ✔  Last GitHub Actions successful
   ℹ  Green GitHub Actions CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/1219204863

@github-actions github-actions bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Sep 9, 2021
@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 9, 2021
@targos targos added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Sep 12, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 12, 2021
@github-actions
Copy link
Contributor

Landed in 90c0a5c...dce7511

@github-actions github-actions bot closed this Sep 12, 2021
nodejs-github-bot pushed a commit that referenced this pull request Sep 12, 2021
@targos @nodejs-github-bot
tools: update all dependencies of markdown linter
dce7511 
PR-URL: #40035
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos deleted the update-lint-md branch September 12, 2021 21:17
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@targos @BethGriggs
tools: update all dependencies of markdown linter
81887aa 
PR-URL: #40035
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@targos @BethGriggs
tools: update all dependencies of markdown linter
d55804c 
PR-URL: #40035
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Sep 21, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@tniessen tniessen tniessen approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@targos @jasnell @lpinca @tniessen @aduh95 @nodejs-github-bot