Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: fix -Wunreachable-code-return error #40034

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/inspector_agent.cc
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,6 @@ inline void* StartIoThreadMain(void* unused) {
if (agent != nullptr)
agent->RequestIoThreadStart();
}
return nullptr;
targos marked this conversation as resolved.
Show resolved Hide resolved
}

static int StartDebugSignalHandler() {
Expand Down
1 change: 0 additions & 1 deletion src/node_url.cc
Original file line number Diff line number Diff line change
Expand Up @@ -600,7 +600,6 @@ std::string URLHost::ToString() const {
case HostType::H_DOMAIN:
case HostType::H_OPAQUE:
return value_.domain_or_opaque;
break;
case HostType::H_IPV4: {
dest.reserve(15);
uint32_t value = value_.ipv4;
Expand Down