Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add more to subsystems #39971

Closed
wants to merge 2 commits into from
Closed

doc: add more to subsystems #39971

wants to merge 2 commits into from

Conversation

iam-frankqiu
Copy link
Contributor

Add benchmark deps typings to subsystems.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 1, 2021
@aduh95
Copy link
Contributor

aduh95 commented Sep 1, 2021

The full list of subsystems can be found at https://github.com/nodejs/core-validate-commit/blob/main/lib/rules/subsystem.js. Maybe we should list them all here, or replace the list with a link to the JS file.

@iam-frankqiu
Copy link
Contributor Author

The full list of subsystems can be found at https://github.com/nodejs/core-validate-commit/blob/main/lib/rules/subsystem.js. Maybe we should list them all here, or replace the list with a link to the JS file.

Good idea. How about this time?

@iam-frankqiu
Copy link
Contributor Author

I don't know what's wrong with my code? I only add several lines of code in the markdown file. But the action of build-windows(windows-2022) still failed. Is it a bug? @nodejs/actions

@aduh95
Copy link
Contributor

aduh95 commented Sep 2, 2021

It is unrelated to your PR, see #39976.

aduh95
aduh95 reviewed Sep 2, 2021
View reviewed changes
doc/guides/contributing/pull-requests.md Outdated Show resolved Hide resolved
doc/guides/contributing/pull-requests.md Outdated Show resolved Hide resolved
@iam-frankqiu iam-frankqiu requested a review from aduh95 September 3, 2021 04:13
@aduh95
Copy link
Contributor

aduh95 commented Sep 3, 2021

Can you fix the linter error please?

@iam-frankqiu
Copy link
Contributor Author

Can you fix the linter error please?

Sure.

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 3, 2021
lpinca
lpinca approved these changes Sep 4, 2021
View reviewed changes
doc/guides/contributing/pull-requests.md Outdated Show resolved Hide resolved
Ayase-252 pushed a commit that referenced this pull request Sep 15, 2021
@iam-frankqiu @Ayase-252
doc: add full list of subsystems
166e52b 
PR-URL: #39971
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Qingyu Deng <[email protected]>
@Ayase-252
Copy link
Member

Landed in 166e52b

@Ayase-252 Ayase-252 closed this Sep 15, 2021
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@iam-frankqiu @BethGriggs
doc: add full list of subsystems
bebbd22 
PR-URL: #39971
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Qingyu Deng <[email protected]>
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@iam-frankqiu @BethGriggs
doc: add full list of subsystems
8aad81d 
PR-URL: #39971
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Qingyu Deng <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Sep 21, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@Ayase-252 Ayase-252 Ayase-252 approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

@tniessen tniessen Awaiting requested review from tniessen

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@iam-frankqiu @aduh95 @Ayase-252 @jasnell @lpinca @tniessen @nodejs-github-bot