Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: register external references of more modules #39961

Closed
wants to merge 10 commits into from
Closed

src: register external references of more modules #39961

wants to merge 10 commits into from

Conversation

joyeecheung
Copy link
Member

These are taken from #38905 and cover most external references that need to be registered for main thread execution.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Aug 31, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39718/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39721/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39726/

@targos
Copy link
Member

targos commented Sep 1, 2021

@nodejs/startup

mhdawson
mhdawson approved these changes Sep 3, 2021
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

joyeecheung added a commit that referenced this pull request Sep 6, 2021
@joyeecheung
src: register external references of dtrace for snapshot
ed13228 
PR-URL: #39961
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
joyeecheung added a commit that referenced this pull request Sep 6, 2021
@joyeecheung
src: register external references of node-report for snapshot
b9ed7e5 
PR-URL: #39961
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
joyeecheung added a commit that referenced this pull request Sep 6, 2021
@joyeecheung
src: register external references of BaseObject for snapshot
afc7760 
PR-URL: #39961
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
joyeecheung added a commit that referenced this pull request Sep 6, 2021
@joyeecheung
src: register missing stream wrap external references
cf11a2b 
PR-URL: #39961
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
joyeecheung added a commit that referenced this pull request Sep 6, 2021
@joyeecheung
src: register missing process methods external references
cca0305 
PR-URL: #39961
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
joyeecheung added a commit that referenced this pull request Sep 6, 2021
@joyeecheung
src: register external references of SignalWrap for snapshot
3ec38f7 
PR-URL: #39961
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
joyeecheung added a commit that referenced this pull request Sep 6, 2021
@joyeecheung
src: register external references of TCPWrap for snapshot
995f945 
PR-URL: #39961
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
joyeecheung added a commit that referenced this pull request Sep 6, 2021
@joyeecheung
src: register external references of TTYWrap for snapshot
6ddcdc3 
PR-URL: #39961
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
joyeecheung added a commit that referenced this pull request Sep 6, 2021
@joyeecheung
src: register external references of PipeWrap for snapshot
1c4df35 
PR-URL: #39961
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@joyeecheung
Copy link
Member Author

joyeecheung commented Sep 6, 2021 •
edited
Loading

Landed in 80785f6...1c4df35

@joyeecheung joyeecheung closed this Sep 6, 2021
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@joyeecheung @BethGriggs
src: register external references of dtrace for snapshot
bef78a2 
PR-URL: #39961
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@joyeecheung @BethGriggs
src: register external references of node-report for snapshot
6fdf025 
PR-URL: #39961
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@joyeecheung @BethGriggs
src: register external references of BaseObject for snapshot
a2c1c3e 
PR-URL: #39961
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@joyeecheung @BethGriggs
src: register missing stream wrap external references
b4e074c 
PR-URL: #39961
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@joyeecheung @BethGriggs
src: register missing process methods external references
db75711 
PR-URL: #39961
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@joyeecheung @BethGriggs
src: register external references of SignalWrap for snapshot
6095fb0 
PR-URL: #39961
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@joyeecheung @BethGriggs
src: register external references of TCPWrap for snapshot
00cca48 
PR-URL: #39961
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@joyeecheung @BethGriggs
src: register external references of TTYWrap for snapshot
7a17cbf 
PR-URL: #39961
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@joyeecheung @BethGriggs
src: register external references of PipeWrap for snapshot
826eee3 
PR-URL: #39961
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Sep 21, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@joyeecheung @nodejs-github-bot @targos @jasnell @addaleax @mhdawson