Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: add mailmap entry for Ethan-Arrowood #39930

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Aug 29, 2021

The next update-authors.js run will add a second entry to AUTHORS for
Ethan-Arrowood because they use a new email address in a commit they
authored very recently. Add the new email address to mailmap and update
AUTHORS.

The next update-authors.js run will add a second entry to AUTHORS for
Ethan-Arrowood because they use a new email address in a commit they
authored very recently. Add the new email address to mailmap and update
AUTHORS.
@Trott Trott added fast-track PRs that do not need to wait for 48 hours to land. and removed fast-track PRs that do not need to wait for 48 hours to land. labels Aug 29, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Aug 29, 2021
@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 29, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@Trott
Copy link
Member Author

Trott commented Aug 29, 2021

(Adding fast-track label so we can land this before the authors.yml change so the first pull request we generate with the workflow can hopefully land without adjustments.)

@Trott
Copy link
Member Author

Trott commented Aug 29, 2021

/ping @Ethan-Arrowood to make sure we are correct with the assumption that the newer address is the preferred address

@Ethan-Arrowood
Copy link
Contributor

Thanks for the ping! Yes new email is correct !

@Lxxyx Lxxyx added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 31, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 31, 2021
@github-actions
Copy link
Contributor

Landed in 9eff819...4e11817

@github-actions github-actions bot closed this Aug 31, 2021
nodejs-github-bot pushed a commit that referenced this pull request Aug 31, 2021
The next update-authors.js run will add a second entry to AUTHORS for
Ethan-Arrowood because they use a new email address in a commit they
authored very recently. Add the new email address to mailmap and update
AUTHORS.

PR-URL: #39930
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
targos pushed a commit that referenced this pull request Sep 6, 2021

Verified

This commit was signed with the committer’s verified signature.
targos Michaël Zasso
The next update-authors.js run will add a second entry to AUTHORS for
Ethan-Arrowood because they use a new email address in a commit they
authored very recently. Add the new email address to mailmap and update
AUTHORS.

PR-URL: #39930
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
targos pushed a commit that referenced this pull request Sep 6, 2021

Verified

This commit was signed with the committer’s verified signature.
BethGriggs Bethany Griggs
The next update-authors.js run will add a second entry to AUTHORS for
Ethan-Arrowood because they use a new email address in a commit they
authored very recently. Add the new email address to mailmap and update
AUTHORS.

PR-URL: #39930
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
@targos targos mentioned this pull request Sep 6, 2021
@Trott Trott deleted the ea-mailmap branch September 25, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants