doc: update WASI example to use import.meta.url #39925
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
tniessen
approved these changes
Aug 28, 2021
aduh95
approved these changes
Aug 28, 2021
Co-authored-by: Antoine du Hamel <[email protected]>
aduh95
reviewed
Aug 29, 2021
Co-authored-by: Antoine du Hamel <[email protected]>
jasnell
approved these changes
Aug 30, 2021
lpinca
approved these changes
Aug 30, 2021
guybedford
added a commit
that referenced
this pull request
Aug 31, 2021
PR-URL: #39925 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
|
Landed in 162f07b. |
targos
pushed a commit
that referenced
this pull request
Sep 6, 2021
PR-URL: #39925 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2021
PR-URL: #39925 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the WASI documentation example to use
import.meta.urlto load the WASI file.This ensures the example follows the more common pattern of a module-relative WASI import rather than a CWD relative one.
At the sime time I've also updated the example to use the FS promises readFile and also noted some WASI binaries need to use the
wasi_unstableimport name.