Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: avoid creating a throw away object in validateObject #39807

Closed
wants to merge 1 commit into from
Closed

lib: avoid creating a throw away object in validateObject #39807

wants to merge 1 commit into from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Aug 19, 2021 •
edited
Loading

This also avoids unexpected behavior if Object.prototype.allowArray et al. is not undefined.

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Aug 19, 2021
@lpinca
Copy link
Member

lpinca commented Aug 20, 2021

This also avoids undefined behavior if Object.prototype.allowArray et al. is not undefined.

Why undefined behavior? allowArray would be the value of Object.prototype.allowArray in that case no?

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 6, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 6, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39842/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39963/

targos pushed a commit that referenced this pull request Sep 18, 2021
@aduh95 @targos
lib: avoid creating a throw away object in validateObject
e62d464 
PR-URL: #39807
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@targos
Copy link
Member

targos commented Sep 18, 2021

Landed in e62d464

@targos targos closed this Sep 18, 2021
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@aduh95 @BethGriggs
lib: avoid creating a throw away object in validateObject
69130ad 
PR-URL: #39807
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@aduh95 @BethGriggs
lib: avoid creating a throw away object in validateObject
6085280 
PR-URL: #39807
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Sep 21, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aduh95 @lpinca @nodejs-github-bot @targos