Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v14.x backport] module: improve support of data: URLs #39669

Closed

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Aug 5, 2021

Add support for loading modules using percent-encoded URLs.

PR-URL: #37392
Reviewed-By: Michaël Zasso [email protected]
Reviewed-By: Bradley Farias [email protected]
Reviewed-By: Myles Borins [email protected]
Reviewed-By: Jan Krems [email protected]
Reviewed-By: Guy Bedford [email protected]
Reviewed-By: Luigi Pinca [email protected]
Reviewed-By: Zijian Liu [email protected]

Add support for loading modules using percent-encoded URLs.

PR-URL: nodejs#37392
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Bradley Farias <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Jan Krems <[email protected]>
Reviewed-By: Guy Bedford <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
@github-actions github-actions bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. v14.x labels Aug 5, 2021
targos pushed a commit that referenced this pull request Aug 8, 2021
Add support for loading modules using percent-encoded URLs.

PR-URL: #37392
Backport-PR-URL: #39669
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Bradley Farias <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Jan Krems <[email protected]>
Reviewed-By: Guy Bedford <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
@targos
Copy link
Member

targos commented Aug 8, 2021

Landed in 29f27a4

@targos targos closed this Aug 8, 2021
@aduh95 aduh95 deleted the v14-percent-encoded-modules branch August 8, 2021 18:33
BethGriggs pushed a commit that referenced this pull request Aug 12, 2021
Add support for loading modules using percent-encoded URLs.

PR-URL: #37392
Backport-PR-URL: #39669
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Bradley Farias <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Jan Krems <[email protected]>
Reviewed-By: Guy Bedford <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 31, 2021
Add support for loading modules using percent-encoded URLs.

PR-URL: #37392
Backport-PR-URL: #39669
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Bradley Farias <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Jan Krems <[email protected]>
Reviewed-By: Guy Bedford <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
Add support for loading modules using percent-encoded URLs.

PR-URL: nodejs#37392
Backport-PR-URL: nodejs#39669
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Bradley Farias <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Jan Krems <[email protected]>
Reviewed-By: Guy Bedford <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants