Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: move gdams to emeritus #39539

Closed
wants to merge 1 commit into from
Closed

meta: move gdams to emeritus #39539

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jul 27, 2021

George does not appear to be active in Node.js for quite some time
(correction welcome!) and my attempts to get in touch have failed.

@Trott
meta: move gdams to emeritus
a381876 
George does not appear to be active in Node.js for quite some time
(correction welcome!) and my attempts to get in touch have failed.
@Trott Trott requested a review from gdams July 27, 2021 02:31
@Trott
Copy link
Member Author

Trott commented Jul 27, 2021

@gdams Please comment if this is not the thing to do at this time and I should close the pull request.

@Trott
Copy link
Member Author

Trott commented Jul 27, 2021 •
edited
Loading

@nodejs/tsc GOVERNANCE.md says TSC can move collaborators to emeritus, so some TSC approvals on this would be useful. It's easy enough to move someone back from emeritus to active status, so an approval does not have to mean "opposed to collaborator status". It can just mean "This PR looks fine and we can move him to emeritus unless and until we hear something contrary."

@Trott Trott added the tsc-agenda Issues and PRs to discuss during the meetings of the TSC. label Jul 27, 2021
mcollina
mcollina approved these changes Jul 27, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jul 27, 2021
gdams
gdams approved these changes Jul 27, 2021
View reviewed changes
Copy link
Member

@gdams gdams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - thanks for doing this @Trott

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 27, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

MylesBorins
MylesBorins approved these changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mhdawson
mhdawson approved these changes Jul 27, 2021
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 27, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 27, 2021
@github-actions
Copy link
Contributor

Landed in 497e5f8...72ccf9f

@github-actions github-actions bot closed this Jul 27, 2021
nodejs-github-bot pushed a commit that referenced this pull request Jul 27, 2021
@Trott @nodejs-github-bot
meta: move gdams to emeritus
72ccf9f 
George does not appear to be active in Node.js for quite some time
(correction welcome!) and my attempts to get in touch have failed.

PR-URL: #39539
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: George Adams <[email protected]>
Reviewed-By: Stewart X Addison <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
danielleadams pushed a commit that referenced this pull request Aug 16, 2021
@Trott @danielleadams
meta: move gdams to emeritus
e428972 
George does not appear to be active in Node.js for quite some time
(correction welcome!) and my attempts to get in touch have failed.

PR-URL: #39539
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: George Adams <[email protected]>
Reviewed-By: Stewart X Addison <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@danielleadams danielleadams mentioned this pull request Aug 16, 2021
Merged
targos pushed a commit that referenced this pull request Sep 4, 2021
@Trott @targos
meta: move gdams to emeritus
fbecae1 
George does not appear to be active in Node.js for quite some time
(correction welcome!) and my attempts to get in touch have failed.

PR-URL: #39539
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: George Adams <[email protected]>
Reviewed-By: Stewart X Addison <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@targos targos mentioned this pull request Sep 4, 2021
Merged
@Trott Trott deleted the gdams-emeritus branch September 25, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@sxa sxa sxa approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@richardlau richardlau richardlau approved these changes

@mcollina mcollina mcollina approved these changes

@ronag ronag ronag approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

@ChALkeR ChALkeR ChALkeR approved these changes

@gdams gdams gdams approved these changes

@tniessen tniessen tniessen approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. tsc-agenda Issues and PRs to discuss during the meetings of the TSC.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.