Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade npm to 7.20.0 #39403

Closed
wants to merge 1 commit into from
Closed

deps: upgrade npm to 7.20.0 #39403

wants to merge 1 commit into from

Conversation

npm-robot
Copy link
Contributor

v7.20.0 (2021-07-15)

FEATURES

BUG FIXES

DOCUMENTATION

DEPENDENCIES

  • 691816f3d @npmcli/[email protected]
    • fixes running prepare scripts for workspaces on reify
    • ensure pacote always compares correct integrity values
  • b9597e944 [email protected]
    • fix: retry socket timeout failures
    • fix: clean up invalid indexes and content after cacache read errors
  • f573e7c56 [email protected]
    • fix: correctly handle error events that happen after response events
  • 2d5797ea0 [email protected]
    • fix: show more actionable messages for git pathspec errors
    • fix: include all dep types when building for prepare
    • fix: do not set mtime when unpacking

@nodejs-github-bot nodejs-github-bot added dont-land-on-v12.x fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. npm Issues and PRs related to the npm client dependency or the npm registry. labels Jul 15, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @nodejs-github-bot. Please 👍 to approve.

@nodejs-github-bot
Copy link
Collaborator

@ruyadorno
Copy link
Member

Landed in 65234bb

@ruyadorno ruyadorno closed this Jul 21, 2021
ruyadorno pushed a commit that referenced this pull request Jul 21, 2021
PR-URL: #39403
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
targos pushed a commit that referenced this pull request Jul 21, 2021
PR-URL: #39403
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Jul 26, 2021
@BethGriggs
Copy link
Member

This PR introduced deps/npm/node_modules/socks/typings/common/receivebuffer.d.ts (via npm/cli#3540) which is causing some weirdness/issues:

warning: the following paths have collided (e.g. case-sensitive paths
on a case-insensitive filesystem) and only one from the same
colliding group is in the working tree:

  'deps/npm/node_modules/socks/typings/common/receiveBuffer.d.ts'
  'deps/npm/node_modules/socks/typings/common/receivebuffer.d.ts'

It was also tripping up one of my git rebase commands (I'm on macOS).

cc: @nodejs/npm

@wraithgar
Copy link

@BethGriggs Yeah this was a painful release to get managed cause of that rename. We've had to hand-fix it during merges of things and I'm not savvy enough w/ git to know how to make it Just Work programmatically.

@BethGriggs
Copy link
Member

@wraithgar is the intent to keep both versions of the file in https://github.com/npm/cli/tree/latest/node_modules/socks/typings/common (and in Node.js core copies)?

@wraithgar
Copy link

No, the intent was to move to the lower case one. Didn't even realize what had gone on under the hood was that the old one somehow was still in the git references. FUN.

https://github.com/npm/cli/tree/latest/node_modules/socks/typings/common

We'll have to get this fixed (again, and for real) in the cli repo it looks like. Not sure what you can do locally to get it to limp along until then.

@BethGriggs
Copy link
Member

@wraithgar ahh thanks, yeah this was a fun one to debug - I can probably work from Linux to get along for now.

@wraithgar
Copy link

npm/cli#3591 This should fix it going forward.

@wraithgar
Copy link

Sorry for the confusion here. socks published with the file lower case and things just went sideways from there.

ronag pushed a commit to nxtedition/node that referenced this pull request Jul 29, 2021
PR-URL: nodejs#39403
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
BethGriggs pushed a commit to BethGriggs/node that referenced this pull request Jul 30, 2021
Updates npm from 7.19.1 to 7.20.3.

Refs: nodejs#39403
PR-URL: nodejs#39579
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
ronag pushed a commit to nxtedition/node that referenced this pull request Aug 1, 2021
PR-URL: nodejs#39403
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
targos pushed a commit that referenced this pull request Aug 2, 2021
Updates npm from 7.19.1 to 7.20.3.

Refs: #39403
PR-URL: #39579
Backport-PR-URL: #39590
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
targos pushed a commit that referenced this pull request Aug 2, 2021
Updates npm from 7.19.1 to 7.20.3.

Refs: #39403
PR-URL: #39579
Backport-PR-URL: #39590
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants