test: mark test-domain-error-types flaky #39369
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refs: nodejs#39368 Signed-off-by: James M Snell <[email protected]>
|
Fast-track has been requested by @jasnell. Please 👍 to approve. |
nodejs-github-bot
added
needs-ci
This comment has been minimized.
This comment has been minimized.
gireeshpunathil
approved these changes
Jul 13, 2021
targos
approved these changes
Jul 13, 2021
|
Landed in 09b57f7 |
jasnell
added a commit
that referenced
this pull request
Jul 13, 2021
Refs: #39368 Signed-off-by: James M Snell <[email protected]> PR-URL: #39369 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jul 17, 2021
Refs: #39368 Signed-off-by: James M Snell <[email protected]> PR-URL: #39369 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Merged
targos
pushed a commit
that referenced
this pull request
Sep 4, 2021
Refs: #39368 Signed-off-by: James M Snell <[email protected]> PR-URL: #39369 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #39368
Signed-off-by: James M Snell [email protected]