Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tls: refactor legacy #39333

Closed
wants to merge 5 commits into from
Closed

tls: refactor legacy #39333

wants to merge 5 commits into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Jul 9, 2021

No description provided.

@ronag ronag added the tls Issues and PRs related to the tls subsystem. label Jul 9, 2021
@ronag ronag requested review from mcollina and jasnell July 9, 2021 22:51
@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jul 9, 2021
@ronag ronag force-pushed the tls-refactor-legacy branch from 05527e6 to 0c8ca4f Compare July 9, 2021 22:51
@ronag ronag force-pushed the tls-refactor-legacy branch from 0c8ca4f to c446fad Compare July 9, 2021 22:53
@ronag
Copy link
Member Author

ronag commented Jul 9, 2021

@nodejs/net

@ronag ronag changed the title Tls refactor legacy tls: refactor legacy Jul 9, 2021
@ronag ronag added request-ci Add this label to start a Jenkins CI on a PR. and removed lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jul 9, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 9, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38928/

mcollina
mcollina approved these changes Jul 10, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronag ronag added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jul 10, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 10, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38936/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38947/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38949/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 10, 2021 •
edited by ronag
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/38950/ ✅

@ronag ronag requested review from aduh95 and BridgeAR July 11, 2021 08:42
aduh95
aduh95 approved these changes Jul 11, 2021
View reviewed changes
lib/internal/tls/parse-cert-string.js
Comment on lines +7 to +10
StringPrototypeIndexOf,
StringPrototypeSlice,
StringPrototypeSplit,
ObjectCreate,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

Suggested change
StringPrototypeIndexOf,
StringPrototypeSlice,
StringPrototypeSplit,
ObjectCreate,
ObjectCreate,
StringPrototypeIndexOf,
StringPrototypeSlice,
StringPrototypeSplit,

ronag added a commit that referenced this pull request Jul 11, 2021
@ronag
tls: move legacy code into own file
5960f16 
PR-URL: #39333
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@ronag
Copy link
Member Author

ronag commented Jul 11, 2021

Landed in 5960f16

@ronag ronag closed this Jul 11, 2021
targos pushed a commit that referenced this pull request Jul 13, 2021
@ronag @targos
tls: move legacy code into own file
dfe99d2 
PR-URL: #39333
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@targos targos mentioned this pull request Jul 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@mcollina mcollina mcollina approved these changes

@jasnell jasnell Awaiting requested review from jasnell

@BridgeAR BridgeAR Awaiting requested review from BridgeAR

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ronag @nodejs-github-bot @mcollina @aduh95 @targos