stream: don't emit prefinish after error or close

[ronag]

No description provided.

[ronag]

@nodejs/streams

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/38927/

[mcollina]

lgtm

[mcollina]

This looks like a patch, but it could be breaking. I've added a labels so that it is not backported to v14 straight away.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/38935/ ✅

[ronag]

Landed in 7a7ba82

[targos]

It doesn't land cleanly on v14.x-staging.

I've added a labels so that it is not backported to v14 straight away.

baking-for-lts is needed for this. We use lts-watch labels to find PRs that people actually want to be backported.

[martin-g]

This change somehow breaks Apache Avro JS module [1] [2]. With Node.js 16 the finish event is not emitted for a Transform anymore. I've added:

.on('prefinish', function () {console.log('--- prefinish');})
    .on('error', function () {console.log('--- error');})
    .on('close', function () {console.log('--- close');})
    .on('finish', function () {
    ...

to the MessageDecoder (a Transformer) but none of them is triggered.

The only way to "fix" the tests is to emit finish manually: apache/avro#1354

Do you have an idea what is going wrong ?

1. https://github.com/apache/avro/blob/8f0b8d68c3fc10b6a5fc09bae4a5c30defe53897/lang/js/lib/protocols.js#L1050-L1103
2. https://github.com/apache/avro/blob/8f0b8d68c3fc10b6a5fc09bae4a5c30defe53897/lang/js/test/test_protocols.js#L200-L219