Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: add find-inactive-collaborators.js #39262

Merged
merged 1 commit into from
Jul 8, 2021

Conversation

Trott
Copy link
Member

@Trott Trott commented Jul 5, 2021

The plan is to eventually call this script with a scheduled GitHub
Action that could automatically open pull requests to move collaborators
to emeritus status after (for example) a year of inactivity.

Sample run:

$ node tools/find-inactive-collaborators.js '30 months ago'
864 authors have made commits since 30 months ago.
101 landers have landed commits since 30 months ago.
146 reviewers have approved landed commits since 30 months ago.
109 collaborators currently in the project.

Inactive collaborators:

Thomas Watson
$

@Trott Trott requested a review from boneskull July 5, 2021 01:15
@github-actions github-actions bot added the tools Issues and PRs related to the tools directory. label Jul 5, 2021
@Trott
Copy link
Member Author

Trott commented Jul 5, 2021

(And yes, I've emailed Thomas as well as a few others to see if they would be amenable to emeritus status at this time.)

@Trott
Copy link
Member Author

Trott commented Jul 5, 2021

This probably needs more robust error handling, but as a tool used internally in the project and not something end users ever run/see, we can also add that later.

This also might be better incorporated into node-core-utils, but that means that the GitHub Action will have to install that every time. I could go either way on it.

@Trott Trott force-pushed the find-inactive-collaborators.js branch from 9367582 to d9c85f4 Compare July 5, 2021 01:49
tools/find-inactive-collaborators.js Outdated Show resolved Hide resolved
tools/find-inactive-collaborators.js Outdated Show resolved Hide resolved
@Trott Trott force-pushed the find-inactive-collaborators.js branch 6 times, most recently from 42fae35 to 912d361 Compare July 5, 2021 23:28
@Trott Trott force-pushed the find-inactive-collaborators.js branch from 912d361 to 42241a8 Compare July 7, 2021 04:21
Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this being checked by eslint? If not, maybe it should be.

@Trott
Copy link
Member Author

Trott commented Jul 8, 2021

Is this being checked by eslint? If not, maybe it should be.

Yes, if I remove a semicolon from the file, make lint-js reports it.

The plan is to eventually call this script with a scheduled GitHub
Action that could automatically open pull requests to move collaborators
to emeritus status after (for example) a year of inactivity.

Sample run:

```
$ node tools/find-inactive-collaborators.mjs '30 months ago'
864 authors have made commits since 30 months ago.
101 landers have landed commits since 30 months ago.
146 reviewers have approved landed commits since 30 months ago.
109 collaborators currently in the project.

Inactive collaborators:

Thomas Watson
$
```

PR-URL: nodejs#39262
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@Trott Trott force-pushed the find-inactive-collaborators.js branch from 42241a8 to 5f3359d Compare July 8, 2021 13:57
@Trott
Copy link
Member Author

Trott commented Jul 8, 2021

Landed in 5f3359d

@Trott Trott merged commit 5f3359d into nodejs:master Jul 8, 2021
@Trott Trott deleted the find-inactive-collaborators.js branch July 8, 2021 13:57
targos pushed a commit that referenced this pull request Jul 11, 2021
The plan is to eventually call this script with a scheduled GitHub
Action that could automatically open pull requests to move collaborators
to emeritus status after (for example) a year of inactivity.

Sample run:

```
$ node tools/find-inactive-collaborators.mjs '30 months ago'
864 authors have made commits since 30 months ago.
101 landers have landed commits since 30 months ago.
146 reviewers have approved landed commits since 30 months ago.
109 collaborators currently in the project.

Inactive collaborators:

Thomas Watson
$
```

PR-URL: #39262
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
targos pushed a commit that referenced this pull request Sep 4, 2021
The plan is to eventually call this script with a scheduled GitHub
Action that could automatically open pull requests to move collaborators
to emeritus status after (for example) a year of inactivity.

Sample run:

```
$ node tools/find-inactive-collaborators.mjs '30 months ago'
864 authors have made commits since 30 months ago.
101 landers have landed commits since 30 months ago.
146 reviewers have approved landed commits since 30 months ago.
109 collaborators currently in the project.

Inactive collaborators:

Thomas Watson
$
```

PR-URL: #39262
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants