-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: remove unused lint-pr-commit-message.sh
#39120
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
tools
Issues and PRs related to the tools directory.
label
Jun 22, 2021
`tools/lint-pr-commit-message.sh` was previously used to lint the commit message of the first commit in a pull request but is now no longer used -- commit message linting is now done in a GitHub actions workflow which does not call this script.
mmarchini
approved these changes
Jun 22, 2021
lpinca
approved these changes
Jun 22, 2021
gengjiawen
approved these changes
Jun 23, 2021
RaisinTen
approved these changes
Jun 23, 2021
Lxxyx
approved these changes
Jul 3, 2021
Lxxyx
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
commit-queue
Add this label to land a pull request using GitHub Actions.
labels
Jul 3, 2021
github-actions
bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Jul 3, 2021
Landed in 975bbbc...8f3d0d6 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Jul 3, 2021
`tools/lint-pr-commit-message.sh` was previously used to lint the commit message of the first commit in a pull request but is now no longer used -- commit message linting is now done in a GitHub actions workflow which does not call this script. PR-URL: #39120 Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Zijian Liu <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jul 11, 2021
`tools/lint-pr-commit-message.sh` was previously used to lint the commit message of the first commit in a pull request but is now no longer used -- commit message linting is now done in a GitHub actions workflow which does not call this script. PR-URL: #39120 Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Zijian Liu <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 4, 2021
`tools/lint-pr-commit-message.sh` was previously used to lint the commit message of the first commit in a pull request but is now no longer used -- commit message linting is now done in a GitHub actions workflow which does not call this script. PR-URL: #39120 Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Zijian Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
tools
Issues and PRs related to the tools directory.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tools/lint-pr-commit-message.sh
was previously used to lint thecommit message of the first commit in a pull request but is now no
longer used -- commit message linting is now done in a GitHub actions
workflow which does not call this script.