Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: remove unused lint-pr-commit-message.sh #39120

Closed
wants to merge 1 commit into from

Conversation

richardlau
Copy link
Member

tools/lint-pr-commit-message.sh was previously used to lint the
commit message of the first commit in a pull request but is now no
longer used -- commit message linting is now done in a GitHub actions
workflow which does not call this script.

@github-actions github-actions bot added the tools Issues and PRs related to the tools directory. label Jun 22, 2021
`tools/lint-pr-commit-message.sh` was previously used to lint the
commit message of the first commit in a pull request but is now no
longer used -- commit message linting is now done in a GitHub actions
workflow which does not call this script.
@Lxxyx Lxxyx added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 3, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 3, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2021

Landed in 975bbbc...8f3d0d6

@github-actions github-actions bot closed this Jul 3, 2021
nodejs-github-bot pushed a commit that referenced this pull request Jul 3, 2021
`tools/lint-pr-commit-message.sh` was previously used to lint the
commit message of the first commit in a pull request but is now no
longer used -- commit message linting is now done in a GitHub actions
workflow which does not call this script.

PR-URL: #39120
Reviewed-By: Mary Marchini <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
targos pushed a commit that referenced this pull request Jul 11, 2021
`tools/lint-pr-commit-message.sh` was previously used to lint the
commit message of the first commit in a pull request but is now no
longer used -- commit message linting is now done in a GitHub actions
workflow which does not call this script.

PR-URL: #39120
Reviewed-By: Mary Marchini <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
targos pushed a commit that referenced this pull request Sep 4, 2021
`tools/lint-pr-commit-message.sh` was previously used to lint the
commit message of the first commit in a pull request but is now no
longer used -- commit message linting is now done in a GitHub actions
workflow which does not call this script.

PR-URL: #39120
Reviewed-By: Mary Marchini <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants