Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: http outgoing setter null test #38881

Closed
wants to merge 2 commits into from

Conversation

ycjcl868
Copy link
Contributor

@ycjcl868 ycjcl868 commented Jun 1, 2021

@github-actions github-actions bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jun 1, 2021
@nodejs-github-bot
Copy link
Collaborator

@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 5, 2021
@Lxxyx Lxxyx added commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Jun 10, 2021
@github-actions github-actions bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 10, 2021
@github-actions
Copy link
Contributor

Commit Queue failed
- Loading data for nodejs/node/pull/38881
✔  Done loading data for nodejs/node/pull/38881
----------------------------------- PR info ------------------------------------
Title      test: http outgoing setter null test (#38881)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     ycjcl868:http-outgoing-setter-test -> nodejs:master
Labels     author ready, test
Commits    2
 - test: http outgoing _headers setter null
 - Update test/parallel/test-http-outgoing-internal-headers.js
Committers 2
 - ycjcl868 <[email protected]>
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/38881
Reviewed-By: James M Snell 
Reviewed-By: Zijian Liu 
Reviewed-By: Darshan Sen 
Reviewed-By: Colin Ihrig 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/38881
Reviewed-By: James M Snell 
Reviewed-By: Zijian Liu 
Reviewed-By: Darshan Sen 
Reviewed-By: Colin Ihrig 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 01 Jun 2021 01:58:07 GMT
   ✔  Approvals: 4
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/38881#pullrequestreview-673163193
   ✔  - Zijian Liu (@Lxxyx): https://github.com/nodejs/node/pull/38881#pullrequestreview-676734762
   ✔  - Darshan Sen (@RaisinTen): https://github.com/nodejs/node/pull/38881#pullrequestreview-676783376
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/38881#pullrequestreview-676804887
   ✔  Last GitHub Actions successful
   ℹ  Last Full PR CI on 2021-06-05T14:09:40Z: https://ci.nodejs.org/job/node-test-pull-request/38500/
- Querying data for job/node-test-pull-request/38500/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/master up to date...
From https://github.com/nodejs/node
 * branch                  master     -> FETCH_HEAD
✔  origin/master is now up-to-date
- Downloading patch for 38881
From https://github.com/nodejs/node
 * branch                  refs/pull/38881/merge -> FETCH_HEAD
✔  Fetched commits as ad27e0e9a187..3554d3cac2e3
--------------------------------------------------------------------------------
[master 9f8e5ecdd6] test: http outgoing _headers setter null
 Author: ycjcl868 <[email protected]>
 Date: Tue Jun 1 09:56:57 2021 +0800
 1 file changed, 11 insertions(+)
[master 3e4716acc5] Update test/parallel/test-http-outgoing-internal-headers.js
 Author: 信鑫-King 
 Date: Tue Jun 1 10:48:24 2021 +0800
 1 file changed, 1 insertion(+), 1 deletion(-)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
test: http outgoing _headers setter null

PR-URL: #38881
Reviewed-By: James M Snell [email protected]
Reviewed-By: Zijian Liu [email protected]
Reviewed-By: Darshan Sen [email protected]
Reviewed-By: Colin Ihrig [email protected]

[detached HEAD 8e6bc0cc18] test: http outgoing _headers setter null
Author: ycjcl868 [email protected]
Date: Tue Jun 1 09:56:57 2021 +0800
1 file changed, 11 insertions(+)
Rebasing (3/4)
Rebasing (4/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Update test/parallel/test-http-outgoing-internal-headers.js

Co-authored-by: Qingyu Deng [email protected]

PR-URL: #38881
Reviewed-By: James M Snell [email protected]
Reviewed-By: Zijian Liu [email protected]
Reviewed-By: Darshan Sen [email protected]
Reviewed-By: Colin Ihrig [email protected]

[detached HEAD 81a4b8d728] Update test/parallel/test-http-outgoing-internal-headers.js
Author: 信鑫-King [email protected]
Date: Tue Jun 1 10:48:24 2021 +0800
1 file changed, 1 insertion(+), 1 deletion(-)

Successfully rebased and updated refs/heads/master.
✔ 8e6bc0cc18162475f08a2341aef9857a4de6d458
✔ 0:0 skipping fixes-url fixes-url
✔ 0:0 blank line after title line-after-title
✔ 0:0 line-lengths are valid line-length
✔ 0:0 metadata is at end of message metadata-end
✔ 1:8 PR-URL is valid. pr-url
✔ 0:0 reviewers are valid reviewers
✔ 0:0 valid subsystems subsystem
✔ 0:0 Title is formatted correctly. title-format
✔ 0:0 Title is <= 50 columns. title-length
✖ 81a4b8d7285e6c9717719525ae85258c1a9fa75b
✔ 0:0 skipping fixes-url fixes-url
✔ 0:0 blank line after title line-after-title
✔ 0:0 line-lengths are valid line-length
✔ 0:0 metadata is at end of message metadata-end
✔ 3:8 PR-URL is valid. pr-url
✔ 0:0 reviewers are valid reviewers
✖ 0:0 Missing subsystem. subsystem
✔ 0:0 Title is formatted correctly. title-format
⚠ 0:50 Title should be <= 50 columns. title-length

ℹ Please fix the commit message and try again.

https://github.com/nodejs/node/actions/runs/926789042

Lxxyx pushed a commit to Lxxyx/node that referenced this pull request Jun 11, 2021
Co-authored-by: Qingyu Deng <[email protected]>

PR-URL: nodejs#38881
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@Lxxyx
Copy link
Member

Lxxyx commented Jun 11, 2021

Landed in d90a41f

@Lxxyx Lxxyx closed this Jun 11, 2021
targos pushed a commit that referenced this pull request Jun 11, 2021
Co-authored-by: Qingyu Deng <[email protected]>

PR-URL: #38881
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@danielleadams danielleadams mentioned this pull request Jun 14, 2021
danielleadams pushed a commit that referenced this pull request Jun 17, 2021
Co-authored-by: Qingyu Deng <[email protected]>

PR-URL: #38881
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
richardlau pushed a commit that referenced this pull request Jul 19, 2021
Co-authored-by: Qingyu Deng <[email protected]>

PR-URL: #38881
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
Co-authored-by: Qingyu Deng <[email protected]>

PR-URL: #38881
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@richardlau richardlau mentioned this pull request Jul 20, 2021
@targos targos removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Sep 5, 2021
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
Co-authored-by: Qingyu Deng <[email protected]>

PR-URL: nodejs#38881
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants