-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: http outgoing setter null test #38881
Conversation
Co-authored-by: Qingyu Deng <[email protected]>
Commit Queue failed- Loading data for nodejs/node/pull/38881 ✔ Done loading data for nodejs/node/pull/38881 ----------------------------------- PR info ------------------------------------ Title test: http outgoing setter null test (#38881) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch ycjcl868:http-outgoing-setter-test -> nodejs:master Labels author ready, test Commits 2 - test: http outgoing _headers setter null - Update test/parallel/test-http-outgoing-internal-headers.js Committers 2 - ycjcl868 <[email protected]> - GitHub PR-URL: https://github.com/nodejs/node/pull/38881 Reviewed-By: James M Snell Reviewed-By: Zijian Liu Reviewed-By: Darshan Sen Reviewed-By: Colin Ihrig ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/38881 Reviewed-By: James M Snell Reviewed-By: Zijian Liu Reviewed-By: Darshan Sen Reviewed-By: Colin Ihrig -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 01 Jun 2021 01:58:07 GMT ✔ Approvals: 4 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/38881#pullrequestreview-673163193 ✔ - Zijian Liu (@Lxxyx): https://github.com/nodejs/node/pull/38881#pullrequestreview-676734762 ✔ - Darshan Sen (@RaisinTen): https://github.com/nodejs/node/pull/38881#pullrequestreview-676783376 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/38881#pullrequestreview-676804887 ✔ Last GitHub Actions successful ℹ Last Full PR CI on 2021-06-05T14:09:40Z: https://ci.nodejs.org/job/node-test-pull-request/38500/ - Querying data for job/node-test-pull-request/38500/ ✔ Build data downloaded ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/master up to date... From https://github.com/nodejs/node * branch master -> FETCH_HEAD ✔ origin/master is now up-to-date - Downloading patch for 38881 From https://github.com/nodejs/node * branch refs/pull/38881/merge -> FETCH_HEAD ✔ Fetched commits as ad27e0e9a187..3554d3cac2e3 -------------------------------------------------------------------------------- [master 9f8e5ecdd6] test: http outgoing _headers setter null Author: ycjcl868 <[email protected]> Date: Tue Jun 1 09:56:57 2021 +0800 1 file changed, 11 insertions(+) [master 3e4716acc5] Update test/parallel/test-http-outgoing-internal-headers.js Author: 信鑫-King Date: Tue Jun 1 10:48:24 2021 +0800 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)https://github.com/nodejs/node/actions/runs/926789042 |
Co-authored-by: Qingyu Deng <[email protected]> PR-URL: nodejs#38881 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Landed in d90a41f |
Co-authored-by: Qingyu Deng <[email protected]> PR-URL: #38881 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Co-authored-by: Qingyu Deng <[email protected]> PR-URL: #38881 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Co-authored-by: Qingyu Deng <[email protected]> PR-URL: #38881 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Co-authored-by: Qingyu Deng <[email protected]> PR-URL: #38881 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Co-authored-by: Qingyu Deng <[email protected]> PR-URL: nodejs#38881 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
https://codecov.io/gh/nodejs/node/src/master/lib/_http_outgoing.js#L184