-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: refactor debuglog init #38838
lib: refactor debuglog init #38838
Conversation
Benchmark CI (misc/startup): https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1033/ Results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Would it also make sense to correct this comment nearby, by replacing debugs
with debugImpls
(it was supposed to be done in #33424)?
node/lib/internal/util/debuglog.js
Lines 15 to 17 in 102f98e
// `debugs` is deliberately initialized to undefined so any call to | |
// debuglog() before initializeDebugEnv() is called will throw. | |
let debugImpls; |
PR-URL: nodejs#38838 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
b152276
to
423ae41
Compare
Landed in 423ae41 |
PR-URL: #38838 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
PR-URL: #38838 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
Alternative to #38756.