-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: clarify synchronous blocking of worker stdio #38658
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean, this is true for literally all Node.js events (or any other runtime with an event loop). I don’t see why we would want to document this for MessagePorts specifically, unless we plan to add a section for this to literally every other event as well.
The issue this references seems to be specifically about the fact that stdio from Workers uses message passing under the hood, and can get blocked by synchronous code on the receiving end, not the sending one. It’s true that that’s not obvious, so if we do document anything, that is what we should document.
Yeah, I was struggling with that a bit also but I think you definitely capture it here... will update :-) |
Fixes: nodejs#25630 Signed-off-by: James M Snell <[email protected]>
a2e26c4
to
01396c4
Compare
Co-authored-by: Antoine du Hamel <[email protected]>
Fixes: #25630 Signed-off-by: James M Snell <[email protected]> PR-URL: #38658 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Landed in 61a67c1 |
Fixes: #25630 Signed-off-by: James M Snell <[email protected]> PR-URL: #38658 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Fixes: #25630 Signed-off-by: James M Snell <[email protected]> PR-URL: #38658 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Fixes: #25630 Signed-off-by: James M Snell <[email protected]> PR-URL: #38658 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Fixes: #25630 Signed-off-by: James M Snell <[email protected]> PR-URL: #38658 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Fixes: #25630 Signed-off-by: James M Snell <[email protected]> PR-URL: #38658 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Fixes: #25630
Signed-off-by: James M Snell [email protected]