Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add lto build to CI #38567

Closed
wants to merge 1 commit into from
Closed

build: add lto build to CI #38567

wants to merge 1 commit into from

Conversation

gengjiawen
Copy link
Member

prevent regression like #38335

@github-actions github-actions bot added the meta Issues and PRs related to the general management of the project. label May 6, 2021
@gengjiawen gengjiawen added the wip Issues and PRs that are still a work in progress. label May 16, 2021
@gengjiawen gengjiawen linked an issue May 16, 2021 that may be closed by this pull request
lto build failed with gcc 9.3 #38570
Closed
@targos
Copy link
Member

targos commented May 17, 2021

The workflow fails early:

Run python configure.py --enable-lto && make -C out/Release v8_snapshot
INFO: configure completed successfully
make: *** out/Release: No such file or directory.  Stop.
Error: Process completed with exit code 2.

@gengjiawen
Copy link
Member Author

The workflow fails early:

Run python configure.py --enable-lto && make -C out/Release v8_snapshot
INFO: configure completed successfully
make: *** out/Release: No such file or directory.  Stop.
Error: Process completed with exit code 2.

Yeap. Mainly to verify this #38570 (comment).

From feedback, it looks like it's a bug in gcc 9.3 .

@gengjiawen gengjiawen force-pushed the lto_test branch 6 times, most recently from bd8f423 to f396bde Compare May 24, 2021 04:11
@gengjiawen gengjiawen removed the wip Issues and PRs that are still a work in progress. label May 24, 2021
@gengjiawen gengjiawen force-pushed the lto_test branch 2 times, most recently from 86ddf3a to 8df9eb4 Compare May 27, 2021 01:57
@gengjiawen gengjiawen requested review from targos and joyeecheung May 27, 2021 06:22
@targos
Copy link
Member

targos commented May 27, 2021

I'm not sure it's worth spending >100 min of computing power on every commit for this :(

@gengjiawen
Copy link
Member Author

I'm not sure it's worth spending >100 min of computing power on every commit for this :(

Is there a way only run it in tag release ?

@gengjiawen gengjiawen requested a review from richardlau May 27, 2021 12:29
targos
targos reviewed May 27, 2021
View reviewed changes
.github/workflows/daily.yml Outdated Show resolved Hide resolved
.github/workflows/daily.yml Outdated Show resolved Hide resolved
@gengjiawen gengjiawen requested a review from targos May 28, 2021 01:50
@gengjiawen
Copy link
Member Author

Landed in ef4bf8f

@gengjiawen gengjiawen closed this May 28, 2021
@gengjiawen gengjiawen deleted the lto_test branch May 28, 2021 11:53
gengjiawen added a commit that referenced this pull request May 28, 2021
@gengjiawen
build: add lto build to CI
ef4bf8f 
PR-URL: #38567
Reviewed-By: James M Snell <[email protected]>
@targos
Copy link
Member

targos commented May 28, 2021

Belated LGTM

danielleadams pushed a commit that referenced this pull request May 31, 2021
@gengjiawen @danielleadams
build: add lto build to CI
24cca7c 
PR-URL: #38567
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request May 31, 2021
Merged
richardlau pushed a commit that referenced this pull request Jul 16, 2021
@gengjiawen @richardlau
build: add lto build to CI
eee39d1 
PR-URL: #38567
Reviewed-By: James M Snell <[email protected]>
richardlau pushed a commit that referenced this pull request Jul 19, 2021
@gengjiawen @richardlau
build: add lto build to CI
2e1c96f 
PR-URL: #38567
Reviewed-By: James M Snell <[email protected]>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
@gengjiawen @richardlau
build: add lto build to CI
7f53a0b 
PR-URL: #38567
Reviewed-By: James M Snell <[email protected]>
@richardlau richardlau mentioned this pull request Jul 20, 2021
Merged
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
@gengjiawen @foxxyz
build: add lto build to CI
96b2554 
PR-URL: nodejs#38567
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@joyeecheung joyeecheung Awaiting requested review from joyeecheung

@richardlau richardlau Awaiting requested review from richardlau

@targos targos Awaiting requested review from targos

Assignees
No one assigned
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lto build failed with gcc 9.3
4 participants
@gengjiawen @targos @jasnell @richardlau