Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: fix hanging of Http2ServerResponse's end method with no data #38561

Closed
wants to merge 1 commit into from
Closed

http2: fix hanging of Http2ServerResponse's end method with no data #38561

wants to merge 1 commit into from

Conversation

pd4d10
Copy link
Contributor

@pd4d10 pd4d10 commented May 5, 2021 •
edited
Loading

Fixes: #38258

@github-actions github-actions bot added http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. labels May 5, 2021
mcollina
mcollina reviewed May 18, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a unit test?

@ofirbarak ofirbarak mentioned this pull request Jan 29, 2022
Merged
nodejs-github-bot pushed a commit that referenced this pull request Feb 3, 2022
@ofirbarak
http2: fix no response event on continue request
be6844d 
When sending a continue request, server response with null,
it does not fires the response event type

Fixes: #38258

PR-URL: #41739
Refs: #38561
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@benjamingr benjamingr closed this Feb 3, 2022
VoltrexKeyva pushed a commit to VoltrexKeyva/node that referenced this pull request Feb 3, 2022
@ofirbarak @VoltrexKeyva
http2: fix no response event on continue request
069ec84 
When sending a continue request, server response with null,
it does not fires the response event type

Fixes: nodejs#38258

PR-URL: nodejs#41739
Refs: nodejs#38561
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
ruyadorno pushed a commit that referenced this pull request Feb 8, 2022
@ofirbarak @ruyadorno
http2: fix no response event on continue request
499171b 
When sending a continue request, server response with null,
it does not fires the response event type

Fixes: #38258

PR-URL: #41739
Refs: #38561
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
@ofirbarak @danielleadams
http2: fix no response event on continue request
b53a7d4 
When sending a continue request, server response with null,
it does not fires the response event type

Fixes: #38258

PR-URL: #41739
Refs: #38561
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
@ofirbarak @danielleadams
http2: fix no response event on continue request
a744b82 
When sending a continue request, server response with null,
it does not fires the response event type

Fixes: #38258

PR-URL: #41739
Refs: #38561
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit to danielleadams/node that referenced this pull request Mar 4, 2022
@ofirbarak @danielleadams
http2: fix no response event on continue request
d9e4501 
When sending a continue request, server response with null,
it does not fires the response event type

Fixes: nodejs#38258

PR-URL: nodejs#41739
Refs: nodejs#38561
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit to danielleadams/node that referenced this pull request Mar 4, 2022
@ofirbarak @danielleadams
http2: fix no response event on continue request
493fc61 
When sending a continue request, server response with null,
it does not fires the response event type

Fixes: nodejs#38258

PR-URL: nodejs#41739
Refs: nodejs#38561
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 8, 2022
@ofirbarak @danielleadams
http2: fix no response event on continue request
cab557c 
When sending a continue request, server response with null,
it does not fires the response event type

Fixes: #38258

PR-URL: #41739
Refs: #38561
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@ofirbarak @danielleadams
http2: fix no response event on continue request
2efe9cb 
When sending a continue request, server response with null,
it does not fires the response event type

Fixes: #38258

PR-URL: #41739
Refs: #38561
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina left review comments

Assignees
No one assigned
Labels
http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

http2: Only first headers cause an event in http2 stream, all following headers are muted.
3 participants
@pd4d10 @mcollina @benjamingr