v16.1.0 release proposal #38522
Merged
v16.1.0 release proposal #38522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Main goal of using a GitHub Action for labelling PRs has been to move the mapping between files changed -> label into a configuration file local to the nodejs/node repository. Previously any changes to that mapping meant having to grasp the nodejs/github-bot project, open a PR with the neccessary changes, get approval from its maintainers before those changes finally got pushed to production. The logic involved in using the file paths / label configuration and resolving the labels to be applied, has been moved into a custom GitHub Action project: nodejs/node-pr-labeler. Aside from removing the external dependency the nodejs-github-bot is in practise, it also reduces the bar for contributors since the resulting project is a lot smaller and less complex than nodejs/github-bot. PR-URL: #38301 Fixes: nodejs/github-bot#294 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
PR-URL: #38399 Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Refs: v8/v8@9.0.257.17...9.0.257.19 PR-URL: #38270 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]>
`output.diagnostic` is a list that is appended to on SmartOS when retrying a test due to `ECONNREFUSED`. The test runner checks if `output.diagnostic` is truthy and, if so, assigns its value to `self.traceback`. However `self.traceback` is supposed to be a string, and `_printDiagnostic()` in the `TapProgressIndicator` attempts to call `splitlines()` on it, which fails if it is a list with: AttributeError: 'list' object has no attribute 'splitlines' PR-URL: #38289 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Christian Clauss <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
While it is extremely unlikely that `.fhqwhgads` will become a valid domain, we should, where possible, use one of the reserved domains for testing. Refs: https://tools.ietf.org/html/rfc2606 PR-URL: #38286 Refs: #38282 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Most of the documentation uses `foo.prototype.bar` notation instead of `foo#bar` notation, this commit apply the former in `buffer.md`. PR-URL: #38032 Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
PR-URL: #38170 Fixes: #38169 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #38217 Reviewed-By: Guy Bedford <[email protected]>
allow no-params read for fsPromises fileHandle read PR-URL: #38287 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #38235 Reviewed-By: Yash Ladha <[email protected]> Reviewed-By: Pooja D P <[email protected]> Reviewed-By: Harshitha K P <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Do not call `.displayPrompt()` twice after the `eval` callback resulted in an error. (This does not affect the default eval because it doesn’t use the callback if an error occurs.) PR-URL: #38314 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #38352 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Nitzan Uziely <[email protected]>
This commit adds a suggestion for a template to be used as part of the security release process. One step of this process is to create an email to nodejs-sec group and currently would contain a copy and pasted version of what is published on nodejs.org. This suggestion is to instead use a link to the blog post. PR-URL: #38290 Refs: #38143 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]>
Several YAML documentation comments incorrectly started with `<!--YAML` instead of `<!-- YAML`, resulting in their content missing in the rendered documentation. PR-URL: #38324 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Fixes: #38305 PR-URL: #38308 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #38311 Fixes: #38302 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
'uint16arr' -> 'uint16array' PR-URL: #38323 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Policy tests can fail if a `package.json` exists in any of the parent directories above the test. The existing checks are done for the ancestors of the test directory but some tests execute from the tmpdir. PR-URL: #38285 Refs: #38088 Refs: #35600 Refs: #35633 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Previously, the code path would allocated a tracked ArrayBuffer that defers cleanup and deallocation of the underlying data with a SetImmediate. Avoid the unnecessary deferral by just allocating a `BackingStore` directly and writing into it. Fixes: #38300 Refs: #38336 PR-URL: #38337 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Signed-off-by: James M Snell <[email protected]> Fixes: #38330 PR-URL: #38331 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
PR-URL: #38213 Refs: #38182 Refs: https://twitter.com/bradleymeck/status/1380643627211354115 Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]>
Fixes: #38341 PR-URL: #38354 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #38357 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #38320 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Refs: #34117 PR-URL: #38356 Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Shingo Inoue <[email protected]>
Refs: #34718 PR-URL: #38355 Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Shingo Inoue <[email protected]>
node-inspect developers have agreed to move node-inspect into core rather than vendor it as a dependency. Refs: #36481 PR-URL: #38161 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
PR-URL: #38161 Refs: #36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Remove code that was for when `node-inspect` was called as a standalone process. PR-URL: #38161 Refs: #36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Fixes: #37224 PR-URL: #38161 Refs: #36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Use a shallow clone instead of cloning the whole repository. PR-URL: #38463 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Fixes: #10555 Signed-off-by: James M Snell <[email protected]> Refs: #10846 PR-URL: #38447 Reviewed-By: Alba Mendez <[email protected]> Reviewed-By: Adrian Estrada <[email protected]>
Reassign `name` and `length` properties to the returned function to not break code that relies on it. PR-URL: #38464 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Rich Trott <[email protected]>
PR-URL: #38465 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Fixes: #33940 PR-URL: #38292 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
This reverts commit b9ffb82. The bug was fixed in libuv 1.41.0. Refs: libuv/libuv#3072 PR-URL: #38494 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #38406 Reviewed-By: Rich Trott <[email protected]>
PR-URL: #38417 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
On some platforms, the TMPDIR environment variable is not set. PR-URL: #38432 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Notice the backslashes are not from the commit messages, seems like a bug in the tool that generates the commit list. |
The tool is https://github.com/nodejs/changelog-maker/ |
|
CITGM looks okay. There are some modules like Jest that fail to be downloaded (error is "Invalid package, must have name and version"), but I can reproduce with v16.0.0 too. |
|
/cc @nodejs/releasers |
richardlau
approved these changes
May 4, 2021
BethGriggs
approved these changes
May 4, 2021
targos
added a commit
to targos/nodejs.org
that referenced
this pull request
May 4, 2021
targos
added a commit
to nodejs/nodejs.org
that referenced
this pull request
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2021-05-04, Version 16.1.0 (Current), @targos
Notable Changes
8a90f55a05] - (SEMVER-MINOR) fs: allow no-params fsPromises fileHandle read (Nitzan Uziely) #38287Commits
28e16488cf] - async_hooks,doc: replace process.stdout.fd with 1 (Darshan Sen) #38382cbab7ec6e5] - benchmark: avoid usingconsole.log()(Antoine du Hamel) #38370ba15b20062] - benchmark: useprocess.hrtime.bigint()(Antoine du Hamel) #38369bc6e719884] - bootstrap: freeze more intrinsics (Antoine du Hamel) #3821729faf0f12e] - build: fix label-pr workflow (Michaël Zasso) #38399b5d669a6ea] - build: label PRs with GitHub Action instead of nodejs-github-bot (Phillip Johnsen) #38301195f679331] - crypto: don't crash with some selfsigned certs (Nils Dralle) #379904b073b0beb] - crypto: fix generateKeyPair type checks (Nitzan Uziely) #38364c1d9b5b386] - crypto: fix scrypt keylen validation (Antoine du Hamel) #383857354479ad5] - crypto: fix DiffieHellmangeneratorvalidation (eladkeyshawn) #383110e446d6048] - debugger: enable linter oninternal/inspector/inspect_client(Antoine du Hamel) #384179f0e80aa4d] - debugger: refactorinternal/inspector/_inspectto use more primordials (Antoine du Hamel) #38406a0c566f85a] - debugger: apply automatic lint fixes for inspect_repl.js (Rich Trott) #38411b884ea739b] - debugger: apply automatic lint fixes for _inspect.js (Rich Trott) #38411f946aa0360] - debugger: remove unused function argument (Rich Trott) #38400203a9689a3] - debugger: align message with Node.js standard (Rich Trott) #38400ef617dcbb0] - debugger: add usage example for--port(Rafael Gonzaga) #3840037b5ce2d5a] - debugger: fix race condition/deadlock on initialization (Rich Trott) #381612a6203d155] - debugger: replace internal use of deprecated API (Rich Trott) #381616fff9fff97] - debugger: allow longer time to connect (Rich Trott) #38161def85daace] - debugger: accommodate line chunking in Windows (Rich Trott) #3816107361e6b77] - debugger: fix inspect restart on Windows (Rich Trott) #38161d65615e119] - debugger: remove unused code (Rich Trott) #3816162b03bc4f6] - debugger: move node-inspect to internal library (Rich Trott) #38161e3b75cb5aa] - deps: V8: cherry-pick fd75c97d3f56 (Michaël Zasso) #38455aabddfbeb5] - deps: upgrade npm to 7.11.2 (Ruy Adorno) #384757b9fb92d51] - deps: update to [email protected] (Guy Bedford) #3845047626c52a3] - deps: patch V8 to 9.0.257.24 (Michaël Zasso) #38423f455e08621] - deps: patch V8 to 9.0.257.21 (Michaël Zasso) #38333dd61a26d8c] - deps: update llhttp to 6.0.1 (Fedor Indutny) #3835905f41cdbcc] - deps: patch V8 to 9.0.257.19 (Michaël Zasso) #38270224faa0a05] - Revert "doc: os.uptime() temporary bug notice" (Michaël Zasso) #384943b0480dde8] - doc: document'secureConnect'event limitation (James M Snell) #3844792586046ec] - doc: fix outdated util inspect documentation and layout example (Ruben Bridgewater) #3707913de4cf1ca] - doc: mark Node.js 10 as End-of-Life (Richard Lau) #384823cbfde1f25] - doc: mark querystring api as legacy (James M Snell) #38436a5929c2487] - doc: update node-api support matrix (Michael Dawson) #38424f08650cefe] - doc: add arguments for stream event of Http2Server and Http2SecureServer (Qingyu Deng) #378922d59273bed] - doc: indicate that abort tests do not generate core files (Rich Trott) #38422f1970127ee] - doc: add try/catch in http2 respondWithFile example (Matteo Collina) #38410f6f1317f43] - doc: note the system requirements for V8 tests (DeeDeeG) #383194b19beaf3c] - doc: minor clarification to pathObject (James M Snell) #384371eae4af6f7] - doc: clarify that fs.Dir async iterator closes automatically (James M Snell) #3843814afb39259] - doc: document new TCP_KEEPCNT and TCP_KEEPINTVL socket option defaults (Arnold Zokas) #38313ed5ef21690] - doc: do not mention TCP in the allowHalfOpen option description (Luigi Pinca) #38360042985c139] - doc: update message to match actual output (Rich Trott) #35271bcc5e2af76] - doc: request default snap track be updated for LTS (Rod Vagg) #37708dfd4c7ba93] - doc: markprocess.hrtime()as legacy (Antoine du Hamel) #3837167cd88da00] - doc: fix typo in worker_threads.md (takayama) #38368a9314cda7d] - doc: fix version history for"exports"patterns (Antoine du Hamel) #3835576885cd578] - doc: fixpackage.json"imports"field history (Antoine du Hamel) #383560e88ae7ec1] - doc: fix typo in buffer.md (divlo) #383231cccc2da51] - doc: fix YAML comment opening tags (Jayden Seric) #3832425052dc987] - doc: add nodejs-sec email template (Daniel Bevenius) #382903858029262] - doc: update TSC members list with three new members (Rich Trott) #383522eef587674] - doc: usefoo.prototype.barnotation in buffer.md (Voltrex) #380328a90f55a05] - (SEMVER-MINOR) fs: allow no-params fsPromises fileHandle read (Nitzan Uziely) #38287a696f1080c] - inspector: remove redundant method for connection check (Yash Ladha) #37986fcac2e0363] - lib: harden lint checks for globals (Antoine du Hamel) #38419277122e1fa] - lib: fix and improve os typings (Akhil Marsonya) #38316f2c0258b4c] - lib: add support for JSTransferable as a mixin (James M Snell) #3838396f54d3446] - meta: post comment when pr labeled fast-track (James M Snell) #384464711f57cf2] - perf_hooks: add toJSON to performance class (Yash Ladha) #37771013fa59602] - perf_hooks: fix PerformanceObserver 'gc' crash (James M Snell) #3841410147f191e] - readline: move utilities to internal modules (Antoine du Hamel) #38466620ee42ab4] - repl: document top level await limitation with const/let (James M Snell) #38449aa24681dcb] - repl: display prompt once after error callback (Anna Henningsen) #383149c06103a4f] - src: fix validation of negative offset to avoid abort (James M Snell) #384217d8cc2abf1] - src: use %progbits instead of @progbits (Stephen Gallagher) #3831217856f1f88] - src: print arbitrary javascript exception value in node report (legendecas) #38009769a210d55] - src: refactor to use THROW_* argument based snprintf (Filip Skokan) #38357e3538bbcd2] - src: fix abort in pbkdf2 (Tobias Nießen) #3835409cacd7418] - src: fix setting Converter sub char length (James M Snell) #383313649ec5276] - src: avoid deferred gc/cleanup for Buffer.from (James M Snell) #38337f2ffaba78c] - stream: the position of _read() is wrong (helloyou2012) #382927ce39b8608] - test: fixcommon.mustCalllengthandnameproperties (Antoine du Hamel) #38464d1cd1178e7] - test: address deprecation warning (Rich Trott) #3844867e9e71f75] - test: crypto KeyObject.from() ERR_INVALID_ARG_TYPE (pezhmanparsaee) #378909ad611c0b2] - test: fix flaky test-crypto-timing-safe-dqual-benchmarks (Rich Trott) #3847610b6b4e244] - test: update url Web Platform Tests (Leko) #384354f6c4eb144] - test: move abort test from pummel to abort directory (Rich Trott) #38396231ef4b0ce] - test: move slower tests into pummel and skip on slow devices (Rich Trott) #3839545322dfa12] - test: skip some pummel tests on slower machines (Rich Trott) #383941bc47a4c0f] - test: fix test to allow quictls fork of OpenSSL 3 (Richard Lau) #383726ac02755f5] - test: extend timeout on debugger tests for slower machines (Rich Trott) #3816193b0c78de0] - test: fix comment typo (Rich Trott) #381616c3e5043b0] - test: fix test-inspector-cli-address (Rich Trott) #3816127d7588ad5] - test: add ancestor package.json checks for tmpdir (Richard Lau) #3828530de03630e] - test: replace function with arrow function and remove unused argument (Andres) #38235eb8f5ce44f] - test: use .test domain for not found address (Richard Lau) #38286a4084d66c6] - test,debugger: migrate node-inspect tests to core (Rich Trott) #3816116eb078aa8] - test,readline: improve tab completion coverage (Antoine du Hamel) #38465b3ca1b358e] - timers: remove redundant unref calls (Giora Guttsait) #383205b393d9258] - tls: validate ticket keys buffer (Antoine du Hamel) #38308f6745e9370] - tls: fixtlsSocket.setMaxSendFragmentabort (eladkeyshawn) #38170499da2d9e3] - tools: use mktemp to create the workspace directory (Luigi Pinca) #384328a83bfd1bd] - tools: use a shallow clone of the npm/cli repository (Luigi Pinca) #38463bec959ef8b] - tools: disable LTO for "v8_cppgc_shared" target (Jesse Chan) #383466350d35b3c] - tools: remove fixer for non-ascii-character ESLint custom rule (Rich Trott) #38413dce8d2968a] - tools: fix doc generation when version info is not available (Antoine du Hamel) #383981033f6c8cb] - tools: add _depot_tools to PATH (for V8 tests) (DeeDeeG) #3829928f02cb8cf] - tools: update ESLint to 7.25.0 (Colin Ihrig) #38378f1ea2c8e2b] - tools: update markdown linter rules (Rich Trott) #3838402e875c645] - tools: remove node-inspect from license (Rich Trott) #38161d3bd4b4771] - tools: fix type mismatch in test runner (Richard Lau) #382899a2651352b] - typings: add JSDoc typings for fs (Voltrex) #38306e389e86b6b] - typings: add JSDoc typings for util (Rohit Gohri) #38213ec5b06eae3] - util: fix infinite recursion during inspection (Ruben Bridgewater) #3707967bd0ec15c] - zlib: fix brotli flush range (Khaidi Chu) #38408