-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: move test-net-connect-econnrefused from pummel to sequential #38462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
labels
Apr 29, 2021
This comment has been minimized.
This comment has been minimized.
antsmartian
approved these changes
Apr 29, 2021
This comment has been minimized.
This comment has been minimized.
addaleax
approved these changes
Apr 29, 2021
cjihrig
approved these changes
Apr 29, 2021
This comment has been minimized.
This comment has been minimized.
jasnell
approved these changes
Apr 29, 2021
lpinca
approved these changes
May 1, 2021
"esems" -> "seems" typo in commit message. |
test-net-connect-econnrefused esems to run quickly on all platforms and does not appear to need to be in the pummel directory. Move to sequential. PR-URL: nodejs#38462 Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Landed in df3465a |
targos
pushed a commit
that referenced
this pull request
May 17, 2021
test-net-connect-econnrefused esems to run quickly on all platforms and does not appear to need to be in the pummel directory. Move to sequential. PR-URL: #38462 Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 30, 2021
test-net-connect-econnrefused esems to run quickly on all platforms and does not appear to need to be in the pummel directory. Move to sequential. PR-URL: #38462 Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jun 5, 2021
test-net-connect-econnrefused esems to run quickly on all platforms and does not appear to need to be in the pummel directory. Move to sequential. PR-URL: #38462 Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jun 5, 2021
test-net-connect-econnrefused esems to run quickly on all platforms and does not appear to need to be in the pummel directory. Move to sequential. PR-URL: #38462 Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jun 11, 2021
test-net-connect-econnrefused esems to run quickly on all platforms and does not appear to need to be in the pummel directory. Move to sequential. PR-URL: #38462 Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test-net-connect-econnrefused esems to run quickly on all platforms and
does not appear to need to be in the pummel directory. Move to
sequential.