-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v14.x backport] doc: update buffer.constants.MAX_LENGTH
#38232
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
buffer
Issues and PRs related to the buffer subsystem.
doc
Issues and PRs related to the documentations.
v14.x
labels
Apr 13, 2021
juanarbol
pushed a commit
to juanarbol/node
that referenced
this pull request
Apr 13, 2021
Fixes: nodejs#38093 PR-URL: nodejs#38109 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Backport-PR-URL: nodejs#38232
juanarbol
force-pushed
the
backport-38109-to-v14.x
branch
from
April 13, 2021 19:38
1cc8010
to
76f6c50
Compare
aduh95
reviewed
Apr 13, 2021
juanarbol
pushed a commit
to juanarbol/node
that referenced
this pull request
Apr 13, 2021
Fixes: nodejs#38093 PR-URL: nodejs#38109 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Backport-PR-URL: nodejs#38232
juanarbol
force-pushed
the
backport-38109-to-v14.x
branch
from
April 13, 2021 23:43
76f6c50
to
48db6a4
Compare
aduh95
previously approved these changes
Apr 13, 2021
targos
reviewed
Apr 14, 2021
Fixes: nodejs#38093 PR-URL: nodejs#38109 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Backport-PR-URL: nodejs#38232
juanarbol
force-pushed
the
backport-38109-to-v14.x
branch
from
April 20, 2021 16:39
48db6a4
to
c25d394
Compare
aduh95
approved these changes
Apr 20, 2021
targos
approved these changes
Apr 20, 2021
targos
pushed a commit
that referenced
this pull request
Apr 24, 2021
Fixes: #38093 PR-URL: #38109 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Backport-PR-URL: #38232
Landed in 9930b6b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #38093
PR-URL: #38109
Reviewed-By: Darshan Sen [email protected]
Reviewed-By: Antoine du Hamel [email protected]
Reviewed-By: James M Snell [email protected]