lib: enforce using `primordials.globalThis` instead of `global` #38230

aduh95 · 2021-04-13T17:00:54Z

global.global may be overwritten in user-land, it's probably safer not to rely on it.

$ echo 'Reflect.defineProperty(globalThis, "global", { get() {throw new Error} })' > pre.js
$ node -r ./pre.js
Welcome to Node.js v15.12.0.
Type ".help" for more information.
/Users/duhamean/Documents/node/f.js:2
  get() {throw new Error}
               ^

Error
    at get (…/pre.js:1:61)
    at REPLServer.createContext (node:repl:1011:5)
    at REPLServer.resetContext (node:repl:1059:23)
    at new REPLServer (node:repl:720:8)
    at Object.start (node:repl:982:10)
    at Object.createRepl [as createInternalRepl] (node:internal/repl:51:21)
    at node:internal/main/repl:41:13
    at Object.loadESM (node:internal/process/esm_loader:68:11)

nodejs-github-bot · 2021-04-13T22:22:14Z

CI: https://ci.nodejs.org/job/node-test-pull-request/37444/ 💚

PR-URL: nodejs#38230 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

aduh95 · 2021-04-17T13:31:40Z

Landed in d756d2b

PR-URL: nodejs#38230 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

PR-URL: #38230 Backport-PR-URL: #39448 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

richardlau · 2021-07-20T10:23:56Z

Backported to v14.x-staging in #39448.

PR-URL: #38230 Backport-PR-URL: #39448 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

PR-URL: nodejs#38230 Backport-PR-URL: nodejs#39448 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

Refs: nodejs#38230 Refs: nodejs#38419

Refs: #38230 Refs: #38419 PR-URL: #42014 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>

Refs: nodejs#38230 Refs: nodejs#38419 PR-URL: nodejs#42014 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>

Refs: #38230 Refs: #38419 PR-URL: #42014 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>

Refs: nodejs#38230 Refs: nodejs#38419 PR-URL: nodejs#42014 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>

Refs: #38230 Refs: #38419 PR-URL: #42014 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>

nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Apr 13, 2021

jasnell approved these changes Apr 13, 2021

View reviewed changes

This comment has been minimized.

Sign in to view

addaleax approved these changes Apr 13, 2021

View reviewed changes

RaisinTen approved these changes Apr 14, 2021

View reviewed changes

aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 14, 2021

Trott approved these changes Apr 14, 2021

View reviewed changes

lpinca approved these changes Apr 14, 2021

View reviewed changes

jasnell removed the needs-ci PRs that need a full CI run. label Apr 14, 2021

VoltrexKeyva approved these changes Apr 15, 2021

View reviewed changes

aduh95 force-pushed the global-primordials branch from 03c63e3 to d756d2b Compare April 17, 2021 13:31

aduh95 merged commit d756d2b into nodejs:master Apr 17, 2021

aduh95 deleted the global-primordials branch April 17, 2021 13:31

BethGriggs mentioned this pull request Apr 20, 2021

2021-04-20, Version 16.0.0 (Current) #37678

Merged

targos added the backport-blocked-v14.x label May 30, 2021

aduh95 mentioned this pull request Jul 19, 2021

[v14.x backport] lint rules for globals #39448

Closed

richardlau added backport-open-v14.x and removed backport-blocked-v14.x labels Jul 19, 2021

richardlau added backported-to-v14.x and removed backport-open-v14.x labels Jul 20, 2021

richardlau mentioned this pull request Jul 20, 2021

v14.17.4 proposal #39466

Merged

aduh95 added a commit to aduh95/node that referenced this pull request Feb 16, 2022

tools,lib: remove global and Intl from the list of globals

4d3de28

Refs: nodejs#38230 Refs: nodejs#38419

aduh95 mentioned this pull request Feb 16, 2022

tools,lib: remove global and Intl from the list of globals #42014

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

lib: enforce using `primordials.globalThis` instead of `global` #38230

lib: enforce using `primordials.globalThis` instead of `global` #38230

aduh95 commented Apr 13, 2021 •

edited

Loading

This comment has been minimized.

nodejs-github-bot commented Apr 13, 2021 •

edited by jasnell

Loading

aduh95 commented Apr 17, 2021

richardlau commented Jul 20, 2021

lib: enforce using primordials.globalThis instead of global #38230

lib: enforce using primordials.globalThis instead of global #38230

Conversation

aduh95 commented Apr 13, 2021 • edited Loading

This comment has been minimized.

nodejs-github-bot commented Apr 13, 2021 • edited by jasnell Loading

aduh95 commented Apr 17, 2021

richardlau commented Jul 20, 2021

lib: enforce using `primordials.globalThis` instead of `global` #38230

lib: enforce using `primordials.globalThis` instead of `global` #38230

aduh95 commented Apr 13, 2021 •

edited

Loading

nodejs-github-bot commented Apr 13, 2021 •

edited by jasnell

Loading