Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove common.disableCrashOnUnhandledRejection #38210

Closed
wants to merge 2 commits into from
Closed

test: remove common.disableCrashOnUnhandledRejection #38210

wants to merge 2 commits into from

Conversation

targos
Copy link
Member

@targos targos commented Apr 12, 2021

Use the --unhandled-rejections=none CLI flag instead.

@targos
test: remove common.disableCrashOnUnhandledRejection
056a45d 
Use the --unhandled-rejections=none CLI flag instead.
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Apr 12, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37399/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37408/

@targos
Copy link
Member Author

targos commented Apr 14, 2021

Landed in 05df701

@targos targos closed this Apr 14, 2021
@targos targos deleted the remove-disableCrashOnUnhandledRejection branch April 14, 2021 14:42
targos added a commit that referenced this pull request Apr 14, 2021
@targos
test: remove common.disableCrashOnUnhandledRejection
05df701 
Use the --unhandled-rejections=none CLI flag instead.

PR-URL: #38210
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
BethGriggs pushed a commit that referenced this pull request Apr 15, 2021
@targos @BethGriggs
test: remove common.disableCrashOnUnhandledRejection
77ab281 
Use the --unhandled-rejections=none CLI flag instead.

PR-URL: #38210
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Apr 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanarbol juanarbol juanarbol approved these changes

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@targos @nodejs-github-bot @jasnell @Trott @cjihrig @richardlau @juanarbol