Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: standardize command flag notes #38199

Closed
wants to merge 1 commit into from
Closed

docs: standardize command flag notes #38199

wants to merge 1 commit into from

Conversation

iguessitsokay
Copy link
Contributor

remove italic styling from command flag notes

based on the below suggestion:
#38171 (review)

@iguessitsokay
docs: standardize command flag notes
27588ad 
remove italic styling from command flag notes
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. vm Issues and PRs related to the vm subsystem. labels Apr 11, 2021
@RaisinTen
Copy link
Contributor

Thanks for the PR. :)
The subsystem in the commit message should be doc instead of docs but that can be fixed while landing.

@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 11, 2021
@jasnell jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 12, 2021
@jasnell
Copy link
Member

jasnell commented Apr 12, 2021

This really shouldn't have to wait the 48 hours to land. Please 👍🏻 to fast-track.

RaisinTen pushed a commit that referenced this pull request Apr 13, 2021
@iguessitsokay @RaisinTen
doc: standardize command flag notes
f1027ec 
remove italic styling from command flag notes

PR-URL: #38199
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@RaisinTen
Copy link
Contributor

Landed in f1027ec

@RaisinTen RaisinTen closed this Apr 13, 2021
BethGriggs pushed a commit that referenced this pull request Apr 15, 2021
@iguessitsokay @BethGriggs
doc: standardize command flag notes
fb3cfc5 
remove italic styling from command flag notes

PR-URL: #38199
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Apr 16, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@iguessitsokay @targos
doc: standardize command flag notes
e6c599b 
remove italic styling from command flag notes

PR-URL: #38199
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
danielleadams pushed a commit that referenced this pull request May 8, 2021
@iguessitsokay @danielleadams
doc: standardize command flag notes
8320e2f 
remove italic styling from command flag notes

PR-URL: #38199
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaisinTen RaisinTen RaisinTen approved these changes

@marsonya marsonya marsonya approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@benjamingr benjamingr benjamingr approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@iguessitsokay @RaisinTen @jasnell @Trott @benjamingr @lpinca @cjihrig @marsonya @nodejs-github-bot