Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: V8: backport d59db06bf542 #38162

Closed
wants to merge 1 commit into from
Closed

deps: V8: backport d59db06bf542 #38162

wants to merge 1 commit into from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Apr 9, 2021

Original commit message:

[weakrefs] Remove --no-harmony-weak-refs flag

Bug: v8:8179
Change-Id: I7f699073807d1874d0c10a4f1641de6bfb0efe6f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2741582
Commit-Queue: Shu-yu Guo <[email protected]>
Reviewed-by: Shu-yu Guo <[email protected]>
Reviewed-by: Adam Klein <[email protected]>
Reviewed-by: Sathya Gunasekaran  <[email protected]>
Cr-Commit-Position: refs/heads/master@{#73871}

Refs: v8/v8@d59db06

@aduh95
deps: V8: backport d59db06bf542
1728990 
Original commit message:

    [weakrefs] Remove --no-harmony-weak-refs flag

    Bug: v8:8179
    Change-Id: I7f699073807d1874d0c10a4f1641de6bfb0efe6f
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2741582
    Commit-Queue: Shu-yu Guo <[email protected]>
    Reviewed-by: Shu-yu Guo <[email protected]>
    Reviewed-by: Adam Klein <[email protected]>
    Reviewed-by: Sathya Gunasekaran  <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#73871}

Refs: v8/v8@d59db06
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Apr 9, 2021
@aduh95 aduh95 mentioned this pull request Apr 9, 2021
Merged
@aduh95 aduh95 marked this pull request as ready for review April 9, 2021 18:09
@aduh95 aduh95 force-pushed the remove-weakref-harmony-flag branch from 598cc34 to 1728990 Compare April 9, 2021 18:09
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 11, 2021 •
edited by targos
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/37377/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/3912/

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 11, 2021
@jasnell
Copy link
Member

jasnell commented Apr 12, 2021

Landed in 2468e4e

@jasnell jasnell closed this Apr 12, 2021
jasnell pushed a commit that referenced this pull request Apr 12, 2021
@aduh95 @jasnell
deps: V8: backport d59db06bf542
2468e4e 
Original commit message:

    [weakrefs] Remove --no-harmony-weak-refs flag

    Bug: v8:8179
    Change-Id: I7f699073807d1874d0c10a4f1641de6bfb0efe6f
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2741582
    Commit-Queue: Shu-yu Guo <[email protected]>
    Reviewed-by: Shu-yu Guo <[email protected]>
    Reviewed-by: Adam Klein <[email protected]>
    Reviewed-by: Sathya Gunasekaran  <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#73871}

Refs: v8/v8@d59db06

PR-URL: #38162
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@aduh95 aduh95 deleted the remove-weakref-harmony-flag branch April 12, 2021 23:14
BethGriggs pushed a commit that referenced this pull request Apr 15, 2021
@aduh95 @BethGriggs
deps: V8: backport d59db06bf542
abc3c37 
Original commit message:

    [weakrefs] Remove --no-harmony-weak-refs flag

    Bug: v8:8179
    Change-Id: I7f699073807d1874d0c10a4f1641de6bfb0efe6f
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2741582
    Commit-Queue: Shu-yu Guo <[email protected]>
    Reviewed-by: Shu-yu Guo <[email protected]>
    Reviewed-by: Adam Klein <[email protected]>
    Reviewed-by: Sathya Gunasekaran  <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#73871}

Refs: v8/v8@d59db06

PR-URL: #38162
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Apr 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aduh95 @nodejs-github-bot @jasnell @targos