doc: add parentheses to function and move reference #38066
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
RaisinTen
approved these changes
Apr 4, 2021
targos
approved these changes
Apr 4, 2021
RaisinTen
added
the
author ready
cjihrig
approved these changes
Apr 4, 2021
marsonya
approved these changes
Apr 4, 2021
lpinca
approved these changes
Apr 4, 2021
Add parentheses as `unref()` is a function. Move it to the correct lexically-sorted location in the reference list. PR-URL: nodejs#38066 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
|
Landed in ab42ef3 |
targos
pushed a commit
that referenced
this pull request
May 1, 2021
Add parentheses as `unref()` is a function. Move it to the correct lexically-sorted location in the reference list. PR-URL: #38066 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add parentheses as
unref()is a function. Move it to the correctlexically-sorted location in the reference list.