build: don't run test workflow on doc dir #37999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
meta
Trott
approved these changes
Apr 2, 2021
|
I thought some add-on tests were constructed from the docs. Am I wrong? |
They are. Perhaps we can remove the change here from test-linux so they still run there, but keep the change to test-macos since that is frequently a bottleneck. |
|
Sgtm |
|
ci may take a little too long. |
Leaving it in the Linux workflow because addons tests are affected by changes to addons.md example code. So we need to keep that running somewhere for docs changes, but one platform seems sufficient. PR-URL: nodejs#37999 Reviewed-By: Rich Trott <[email protected]>
|
Landed in f5eea17. I only landed the macOS change and left the current Linux workflow as-is based on the discussion above. We can always add an ignore paths directive for the Linux workflow at a later date. (I imagine it's possible to ignore-paths on everything except |
targos
pushed a commit
that referenced
this pull request
May 1, 2021
Leaving it in the Linux workflow because addons tests are affected by changes to addons.md example code. So we need to keep that running somewhere for docs changes, but one platform seems sufficient. PR-URL: #37999 Reviewed-By: Rich Trott <[email protected]>
Merged
danielleadams
pushed a commit
that referenced
this pull request
May 8, 2021
Leaving it in the Linux workflow because addons tests are affected by changes to addons.md example code. So we need to keep that running somewhere for docs changes, but one platform seems sufficient. PR-URL: #37999 Reviewed-By: Rich Trott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore the
docdirectory when running test workflow.Checklist