-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: add GitHub Action for coverage with --without-intl #37954
Conversation
Here's the diff between the existing Linux coverage job and this one:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, although since the diff to the existing Linux coverage job is so small maybe consider matrixing the existing workflow?
@Trott it looks like the issue is that the inspector is not enabled does |
Yes, it indeed disables the inspector. Lines 545 to 549 in 7823759
|
Can you try to remove this line? Line 1797 in 7823759
Maybe it is now possible to enable the inspector without intl. |
Done and force-pushed. Now we wait... 🤞 |
This comment has been minimized.
This comment has been minimized.
Well I just tried locally and it failed in our source:
|
It seems we only include ICU to convert UTF-8 to UTF-16 (at least in this file). Maybe V8 has an API for that? |
My C++ is not good, but does it seem do-able using |
There's also https://github.com/nodejs/node/blob/master/src/inspector/node_string.cc I'm not good enough with C++ to tell whether it can be rewritten using V8 APIs instead of ICU. |
bcb01c8
to
5df1334
Compare
3545058
to
f313d1c
Compare
Maybe @addaleax can answer our questions about string conversion. |
So, if the issue is converting from UTF-8 to UTF-16, then There’s also built-in C++ standard utilities in the And finally, there’s always the option of using some external code for this job. I don’t think that would be the end of the world in any way. |
f313d1c
to
f6a1e5a
Compare
I think I got it working in src/inspector/main_thread_interface.cc but I still have to do it for |
f6a1e5a
to
47fad38
Compare
|
d68418b
to
5c0f877
Compare
🎉 It's green! |
I think this is the codecov result: https://app.codecov.io/gh/nodejs/node/commit/5c0f877885136cef6a0f12894688c6fc4e7ad2c2 |
And here's the |
Because this changes |
This is so good. Thank you everybody! |
Landed in 3c6547f...4ba860e |
PR-URL: #37954 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
There are parts of the code base that require a build without intl to be covered. So add a coverage job to build --without-intl. PR-URL: #37954 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
PR-URL: #37954 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
There are parts of the code base that require a build without intl to be covered. So add a coverage job to build --without-intl. PR-URL: #37954 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
PR-URL: #37954 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
There are parts of the code base that require a build without intl to be covered. So add a coverage job to build --without-intl. PR-URL: #37954 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
PR-URL: #37954 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
There are parts of the code base that require a build without intl to be covered. So add a coverage job to build --without-intl. PR-URL: #37954 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
There are parts of the code base that require a build without intl to be
covered. So add a coverage job to build --without-intl.