Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v14.x] doc: mark modules implementation as stable #37719

Closed

Conversation

MylesBorins
Copy link
Contributor

We had kept the implementation as experimental to leave room for large changes that might land prior to 16. With the Semver-Major cut-off looming I don't think we'll be seeing any. Let's mark ESM stable and make it clear that folks can use this in prod

PR-URL: #35781
Reviewed-By: Matteo Collina [email protected]
Reviewed-By: Benjamin Gruenbaum [email protected]
Reviewed-By: Rich Trott [email protected]
Reviewed-By: Michaël Zasso [email protected]
Reviewed-By: Franziska Hinkelmann [email protected]
Reviewed-By: James M Snell [email protected]
Reviewed-By: Myles Borins [email protected]
Reviewed-By: Antoine du Hamel [email protected]
Reviewed-By: Derek Lewis [email protected]

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. v14.x labels Mar 11, 2021
@MylesBorins MylesBorins requested a review from guybedford March 11, 2021 22:19
@MylesBorins
Copy link
Contributor Author

/cc @nodejs/modules

@MylesBorins MylesBorins added the semver-minor PRs that contain new features and should be released in the next minor version. label Mar 15, 2021
@DerekNonGeneric DerekNonGeneric added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 2, 2021
PR-URL: nodejs#35781
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Derek Lewis <[email protected]>
@targos targos force-pushed the modules-stable-v14.x branch from ea8be7b to e2adae0 Compare April 24, 2021 12:54
@targos
Copy link
Member

targos commented Apr 24, 2021

Landed in c1af593

@targos targos closed this Apr 24, 2021
targos pushed a commit that referenced this pull request Apr 24, 2021
PR-URL: #35781
Backport-PR-URL: #37719
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Derek Lewis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants