-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v14.x] doc: mark modules implementation as stable #37719
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/cc @nodejs/modules |
guybedford
approved these changes
Mar 11, 2021
aduh95
approved these changes
Mar 11, 2021
GeoffreyBooth
approved these changes
Mar 12, 2021
marsonya
approved these changes
Mar 15, 2021
MylesBorins
added
the
semver-minor
PRs that contain new features and should be released in the next minor version.
label
Mar 15, 2021
BethGriggs
approved these changes
Mar 23, 2021
DerekNonGeneric
approved these changes
Mar 23, 2021
DerekNonGeneric
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Apr 2, 2021
MylesBorins
force-pushed
the
v14.x-staging
branch
from
April 6, 2021 19:54
11505ad
to
6b115d7
Compare
PR-URL: nodejs#35781 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Derek Lewis <[email protected]>
targos
force-pushed
the
modules-stable-v14.x
branch
from
April 24, 2021 12:54
ea8be7b
to
e2adae0
Compare
Landed in c1af593 |
targos
pushed a commit
that referenced
this pull request
Apr 24, 2021
PR-URL: #35781 Backport-PR-URL: #37719 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Derek Lewis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
doc
Issues and PRs related to the documentations.
semver-minor
PRs that contain new features and should be released in the next minor version.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had kept the implementation as experimental to leave room for large changes that might land prior to 16. With the Semver-Major cut-off looming I don't think we'll be seeing any. Let's mark ESM stable and make it clear that folks can use this in prod
PR-URL: #35781
Reviewed-By: Matteo Collina [email protected]
Reviewed-By: Benjamin Gruenbaum [email protected]
Reviewed-By: Rich Trott [email protected]
Reviewed-By: Michaël Zasso [email protected]
Reviewed-By: Franziska Hinkelmann [email protected]
Reviewed-By: James M Snell [email protected]
Reviewed-By: Myles Borins [email protected]
Reviewed-By: Antoine du Hamel [email protected]
Reviewed-By: Derek Lewis [email protected]