Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v12.x] doc: mark modules implementation as stable #37718

Merged
merged 1 commit into from
Mar 17, 2021

Conversation

MylesBorins
Copy link
Contributor

We had kept the implementation as experimental to leave room for large changes that might land prior to 16. With the Semver-Major cut-off looming I don't think we'll be seeing any. Let's mark ESM stable and make it clear that folks can use this in prod

PR-URL: #35781
Reviewed-By: Matteo Collina [email protected]
Reviewed-By: Benjamin Gruenbaum [email protected]
Reviewed-By: Rich Trott [email protected]
Reviewed-By: Michaël Zasso [email protected]
Reviewed-By: Franziska Hinkelmann [email protected]
Reviewed-By: James M Snell [email protected]
Reviewed-By: Myles Borins [email protected]
Reviewed-By: Antoine du Hamel [email protected]
Reviewed-By: Derek Lewis [email protected]

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. v12.x labels Mar 11, 2021
@MylesBorins MylesBorins requested a review from guybedford March 11, 2021 22:19
@MylesBorins
Copy link
Contributor Author

/cc @nodejs/modules

PR-URL: nodejs#35781
Backport-PR-URL: nodejs#37718
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Derek Lewis <[email protected]>
@richardlau richardlau force-pushed the modules-stable-v12.x branch from 467a54f to bf8733f Compare March 17, 2021 21:23
@richardlau
Copy link
Member

Landed in bf8733f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants