Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tls: refactor to avoid unsafe array iteration #37655

Merged
merged 1 commit into from
Mar 13, 2021
Merged

tls: refactor to avoid unsafe array iteration #37655

merged 1 commit into from
Mar 13, 2021

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Mar 8, 2021

No description provided.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. tls Issues and PRs related to the tls subsystem. labels Mar 8, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36533/

@Lxxyx Lxxyx added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Mar 8, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36671/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36675/

@aduh95
tls: refactor to avoid unsafe array iteration
c2a792f 
PR-URL: nodejs#37655
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@aduh95 aduh95 force-pushed the tls-array-iteration branch from fe358f9 to c2a792f Compare March 13, 2021 10:47
@aduh95
Copy link
Contributor Author

aduh95 commented Mar 13, 2021

Landed in c2a792f

@aduh95 aduh95 merged commit c2a792f into nodejs:master Mar 13, 2021
@aduh95 aduh95 deleted the tls-array-iteration branch March 13, 2021 10:47
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
@aduh95 @danielleadams
tls: refactor to avoid unsafe array iteration
311ddc9 
PR-URL: #37655
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@danielleadams danielleadams mentioned this pull request Mar 16, 2021
Merged
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
@aduh95 @danielleadams
tls: refactor to avoid unsafe array iteration
2d9b624 
PR-URL: #37655
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaisinTen RaisinTen RaisinTen approved these changes

@Lxxyx Lxxyx Lxxyx approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aduh95 @nodejs-github-bot @Trott @Lxxyx @RaisinTen @targos