test: fix test-doctool-html #37397
Merged
test: fix test-doctool-html #37397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
|
fast-track? |
danielleadams
approved these changes
Feb 16, 2021
Trott
approved these changes
Feb 16, 2021
There was a problem hiding this comment.
LGTM. Mild preference for @danielleadams's suggestion for balancing the opening/closing tags in the result fragment, but fine either way.
RaisinTen
approved these changes
Feb 16, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
aduh95
added
the
author ready
This comment has been minimized.
This comment has been minimized.
Refs: nodejs#37301 PR-URL: nodejs#37397 Reviewed-By: Danielle Adams <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
aduh95
force-pushed
the
doctool-fix-tests
branch
from
b3b569a to
1c6484b
Compare
|
Landed in 1c6484b |
danielleadams
pushed a commit
that referenced
this pull request
Feb 16, 2021
Refs: #37301 PR-URL: #37397 Reviewed-By: Danielle Adams <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 1, 2021
Refs: #37301 PR-URL: #37397 Reviewed-By: Danielle Adams <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #37301