crypto: generateKeyPair('ec') should not support NODE-ED* and NODE-X* #37063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
tniessen
reviewed
Jan 25, 2021
tniessen
reviewed
Jan 25, 2021
|
I still have to manage to change |
panva
commented
Jan 25, 2021
src/crypto/crypto_ecdh.cc
Outdated
| @@ -443,7 +447,7 @@ Maybe<bool> ECDHBitsTraits::AdditionalConfig( | |||
| return Nothing<bool>(); | |||
| } | |||
|
|
|||
| params->id_ = GetCurveFromName(*name); | |||
| params->id_ = GetOKPCurveFromName(*name); | |||
There was a problem hiding this comment.
AFAICT id_ is only used to discern between X25519, X448 and then it throws everything else in the default bucket anyway, therefore returning the specific EC curve ids is not necessary and using GetOKPCurveFromName is ok.
Co-authored-by: Tobias Nießen <[email protected]>
jasnell
approved these changes
Jan 25, 2021
panva
added
the
author ready
tniessen
approved these changes
Jan 25, 2021
juanarbol
approved these changes
Jan 26, 2021
panva
added a commit
that referenced
this pull request
Jan 27, 2021
Fixes #37055 PR-URL: #37063 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
|
Landed in 8b65004 |
targos
pushed a commit
that referenced
this pull request
Feb 2, 2021
Fixes #37055 PR-URL: #37063 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following "curves" were added to the
'ec'key type in #36879.NODE-ED25519NODE-ED448NODE-X25519NODE-X448However, none of these are pure EC curves, for example, Curve25519 does not work with ECDSA, which is one of the reasons why
crypto.getCurves()does not include Curve25519. This PR makes these "curves" only recognized from the Web Cryptography API experimental interface.Fixes #37055
cc @jasnell @tniessen