Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve coverage of SourceTextModule getters #37013

Merged
merged 0 commits into from
Jan 24, 2021
Merged

test: improve coverage of SourceTextModule getters #37013

merged 0 commits into from
Jan 24, 2021

Conversation

juanarbol
Copy link
Member

No description provided.

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 21, 2021
@juanarbol juanarbol force-pushed the juanarbol/sourcetextmodule-code-coverage branch from 5a34564 to feca4cf Compare January 21, 2021 22:03
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35670/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35678/

@juanarbol juanarbol added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 23, 2021
@Trott
Copy link
Member

Trott commented Jan 24, 2021

Landed in 6b62f70

@Trott Trott closed this Jan 24, 2021
@Trott Trott force-pushed the juanarbol/sourcetextmodule-code-coverage branch from feca4cf to 6b62f70 Compare January 24, 2021 15:33
@Trott Trott merged commit 6b62f70 into nodejs:master Jan 24, 2021
@juanarbol juanarbol deleted the juanarbol/sourcetextmodule-code-coverage branch January 29, 2021 18:14
targos pushed a commit that referenced this pull request Feb 2, 2021
@juanarbol @targos
test: improve coverage of SourceTextModule getters
de6dca1 
PR-URL: #37013
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@targos targos mentioned this pull request Feb 2, 2021
Merged
targos pushed a commit that referenced this pull request May 25, 2021
@juanarbol @targos
test: improve coverage of SourceTextModule getters
717f0bd 
PR-URL: #37013
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request May 30, 2021
@juanarbol @targos
test: improve coverage of SourceTextModule getters
d9293a3 
PR-URL: #37013
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Jun 5, 2021
@juanarbol @targos
test: improve coverage of SourceTextModule getters
de6b446 
PR-URL: #37013
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@targos targos mentioned this pull request Jun 6, 2021
Merged
targos pushed a commit that referenced this pull request Jun 11, 2021
@juanarbol @targos
test: improve coverage of SourceTextModule getters
836fba5 
PR-URL: #37013
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaisinTen RaisinTen RaisinTen approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@juanarbol @nodejs-github-bot @Trott @lpinca @RaisinTen