-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: update lts description in the collaborator guide #3668
Conversation
documentation updates, and certain performance improvements that can be | ||
demonstrated to not break existing applications. Semver-minor changes are only | ||
permitted if required for bug fixes and then only on a case-by-case basis with | ||
LTS WG and possibly TSC review. Semver-major changes are only permitted if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TSC -> CTC
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sigh. I'm gonna start just using random letters instead
@trevnorris ... updated. PTAL |
@nodejs/lts ... ping |
|
||
Once a stable branch moves into Maintenance mode, only **critical** bugs, **critical** security fixes, | ||
and documentation updates will be permitted. | ||
Once a stable branch enters LTS, no new features may be added to that release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that true? It seems that it's a bit more subtle than that. See #3609 for instance. It seems that the text below:
Semver-minor changes are only permitted if required for bug fixes and then only on a case-by-case basis with LTS WG and possibly Core Technical Committee (CTC) review.
actually describes this subtle situation better, and that that phrase might actually not be needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. Missed that one :-) Will fix!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@jasnell Added some comments. |
@misterdjules ... updated to fix the first comment (#3668 (comment)) |
@jasnell LGTM, thank you! |
PR-URL: #3668 Reviewed-By: Julien Gilli <[email protected]>
Landed in dac387e |
PR-URL: #3668 Reviewed-By: Julien Gilli <[email protected]>
PR-URL: #3668 Reviewed-By: Julien Gilli <[email protected]>
landed in v4.x-staging in 9970b76 |
PR-URL: #3668 Reviewed-By: Julien Gilli <[email protected]>
PR-URL: #3668 Reviewed-By: Julien Gilli <[email protected]>
PR-URL: #3668 Reviewed-By: Julien Gilli <[email protected]>
Update description of the LTS process in the collaborators guide based on the
current practice. @nodejs/lts