-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inadvertent disclosure #36155
Closed
Closed
Inadvertent disclosure #36155
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
83c1c12
doc: add process for handling premature disclosure
mhdawson b11e4d5
Update doc/guides/collaborator-guide.md
mhdawson 2d2004d
fixup
mhdawson 04c0058
squash: fixup
mhdawson 0e2c90c
fixup
mhdawson 9a85ac9
fixup
mhdawson 9bc5247
Update doc/guides/collaborator-guide.md
mhdawson c97676c
Update doc/guides/collaborator-guide.md
mhdawson 7e4de86
fixup[
mhdawson efe89c4
Update doc/guides/collaborator-guide.md
mhdawson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,6 +7,7 @@ | |
| * [Closing issues and pull requests](#closing-issues-and-pull-requests) | ||
| * [Author ready pull requests](#author-ready-pull-requests) | ||
| * [Handling own pull requests](#handling-own-pull-requests) | ||
| * [Security issues](#managing-security-issues) | ||
| * [Accepting modifications](#accepting-modifications) | ||
| * [Code reviews](#code-reviews) | ||
| * [Consensus seeking](#consensus-seeking) | ||
|
|
@@ -87,6 +88,33 @@ to land but is [author ready](#author-ready-pull-requests), add the | |
| `author ready` label. If you wish to land the pull request yourself, use the | ||
| "assign yourself" link to self-assign it. | ||
|
|
||
| ### Managing security issues | ||
|
|
||
| Security issues should ideally be reported through the processes outlined in | ||
| [SECURITY.md][security reporting]. This allows the collaborators to | ||
| appropriately triage the report and address vulnerabilities in a planned | ||
| security release. If an issue is opened in the public repo | ||
| which describes a security issue, or if an issue is later identified to be | ||
| describing a security issue, take the following steps: | ||
|
|
||
| * Ask the originator to submit a report through Hacker one as outlined in | ||
| [SECURITY.md][security reporting]. | ||
| * Move the issue to the private repo called `premature-disclosures` | ||
mhdawson marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| * For any related pull requests create an associated issue in the | ||
| `premature-disclosures` repo and add a copy of the patch for the | ||
| pull request, and screenshots of discussion on the PR to the issue. | ||
| * Open a ticket with GitHub asking that the PRs be deleted through | ||
| [GitHub suppport](https://support.github.com/contact) | ||
| using Node.js(team) as the account organization. | ||
| * Open a new issue in the repository in which the issue was originally | ||
| reported with a brief FYI to the originator. `FYI @xxxx we asked github | ||
| to delete your PR while we work on releases in private.` with the title | ||
| `FYI - PR deleted #YYYY`. | ||
| * Email `[email protected]` with the link to the issues in the | ||
| `premature-disclosures` repo so that the TSC is aware that they | ||
| may need to expidite handling of the issue due to premature | ||
mhdawson marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| disclosure. | ||
|
|
||
| ## Accepting modifications | ||
|
|
||
| Contributors propose modifications to Node.js using GitHub pull requests. This | ||
|
|
@@ -792,3 +820,4 @@ If you cannot find who to cc for a file, `git shortlog -n -s <file>` can help. | |
| [node-core-utils-credentials]: https://github.com/nodejs/node-core-utils#setting-up-credentials | ||
| [node-core-utils-issues]: https://github.com/nodejs/node-core-utils/issues | ||
| [unreliable tests]: https://github.com/nodejs/node/issues?q=is%3Aopen+is%3Aissue+label%3A%22CI+%2F+flaky+test%22 | ||
| [security reporting]: https://github.com/nodejs/SECURITY.md | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Link to the repository? Or should we keep it without a link on purpose?
Also, I assume it will be a repo on nodejs-private?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've not created the repo yet, but a link makes sense. It should only be accessible to those who have access to private repos within the org
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mmarchini added the link in the first reference, not sure if we need to make all references a link or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, its a private repo in the nodejs org as I don't believe we can move issues across organizations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. The downside is that folks who have access to private repos in this org but not on the repo we usually use for security releases will have access to the issue. It's probably fine though, it only means some folks in moderation and CommComm will have access to the issue even when they don't have access to security release discussions (which is still better than keeping the issue public).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mmarchini
+1