internal: refactor to use more primordials #36140
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
approved these changes
Nov 18, 2020
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
jasnell
approved these changes
Nov 19, 2020
aduh95
added
the
commit-queue
github-actions
bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/36140 ✔ Done loading data for nodejs/node/pull/36140 ----------------------------------- PR info ------------------------------------ Title internal: refactor to use more primordials (#36140) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:main-primordials -> nodejs:master Labels author ready Commits 1 - internal: refactor to use more primordials Committers 1 - Antoine du Hamel PR-URL: https://github.com/nodejs/node/pull/36140 Reviewed-By: Rich Trott Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/36140 Reviewed-By: Rich Trott Reviewed-By: James M Snell -------------------------------------------------------------------------------- ✔ Last GitHub Actions successful ℹ Last Full PR CI on 2020-11-18T13:54:23Z: https://ci.nodejs.org/job/node-test-pull-request/34452/ - Querying data for job/node-test-pull-request/34452/ ✔ Build data downloaded ✔ Last Jenkins CI successful ℹ This PR was created on Mon, 16 Nov 2020 23:09:37 GMT ✔ Approvals: 2 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/36140#pullrequestreview-533395778 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/36140#pullrequestreview-534528748 -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/master up to date... From https://github.com/nodejs/node * branch master -> FETCH_HEAD ✔ origin/master is now up-to-date - Downloading patch for 36140 From https://github.com/nodejs/node * branch refs/pull/36140/merge -> FETCH_HEAD ✔ Fetched commits as 275aa6845ea7..63bbbf57b02a -------------------------------------------------------------------------------- [master f60270928c] internal: refactor to use more primordials Author: Antoine du Hamel Date: Sun Nov 15 19:18:33 2020 +0100 2 files changed, 31 insertions(+), 19 deletions(-) ✔ Patches applied -------------------------------------------------------------------------------- --------------------------------- New Message ---------------------------------- internal: refactor to use more primordialshttps://github.com/nodejs/node/actions/runs/372812416 |
aduh95
added a commit
that referenced
this pull request
Nov 19, 2020
PR-URL: #36140 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in 3e0194e |
codebytere
pushed a commit
that referenced
this pull request
Nov 22, 2020
PR-URL: #36140 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
targos
pushed a commit
that referenced
this pull request
May 16, 2021
PR-URL: #36140 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jun 11, 2021
PR-URL: #36140 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
removed
the
commit-queue-failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes