Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: remove modules that require intl #35968

Closed
wants to merge 1 commit into from
Closed

benchmark: remove modules that require intl #35968

wants to merge 1 commit into from

Conversation

richardlau
Copy link
Member

inspector and trace_events will throw errors if Node.js has been
compiled with --without-intl.

Fixes: #35962
Refs: #35816

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@richardlau
benchmark: remove modules that require intl
893ac61 
`inspector` and `trace_events` will throw errors if Node.js has been
compiled with `--without-intl`.

Refs: nodejs#35816
@nodejs-github-bot nodejs-github-bot added the benchmark Issues and PRs related to the benchmark subsystem. label Nov 4, 2020
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 4, 2020
@richardlau richardlau mentioned this pull request Nov 4, 2020
Closed
@richardlau
Copy link
Member Author

CI is currently broken so I suggest we either fast track this or revert #35816.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 4, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34068/

@targos targos mentioned this pull request Nov 4, 2020
Merged
@richardlau richardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 4, 2020
@HarshithaKP HarshithaKP added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 5, 2020
@github-actions github-actions bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 5, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2020

Commit Queue failed
- Loading data for nodejs/node/pull/35968
✔  Done loading data for nodejs/node/pull/35968
----------------------------------- PR info ------------------------------------
Title      benchmark: remove modules that require intl (#35968)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     richardlau:benchmark -> nodejs:master
Labels     author ready, benchmark
Commits    1
 - benchmark: remove modules that require intl
Committers 1
 - Richard Lau 
PR-URL: https://github.com/nodejs/node/pull/35968
Fixes: https://github.com/nodejs/node/issues/35962
Refs: https://github.com/nodejs/node/pull/35816
Reviewed-By: Luigi Pinca 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Harshitha K P 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/35968
Fixes: https://github.com/nodejs/node/issues/35962
Refs: https://github.com/nodejs/node/pull/35816
Reviewed-By: Luigi Pinca 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Harshitha K P 
--------------------------------------------------------------------------------
   ✔  Last GitHub Actions successful
   ℹ  Last Full PR CI on 2020-11-04T19:59:57Z: https://ci.nodejs.org/job/node-test-pull-request/34068/
- Querying data for job/node-test-pull-request/34068/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
   ℹ  This PR was created on Wed, 04 Nov 2020 19:50:59 GMT
   ✔  Approvals: 4
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/35968#pullrequestreview-523701554
   ✔  - Antoine du Hamel (@aduh95): https://github.com/nodejs/node/pull/35968#pullrequestreview-523791974
   ✔  - Gireesh Punathil (@gireeshpunathil) (TSC): https://github.com/nodejs/node/pull/35968#pullrequestreview-523865110
   ✔  - Harshitha K P (@HarshithaKP): https://github.com/nodejs/node/pull/35968#pullrequestreview-523916500
   ✖  This PR needs to wait 38 more hours to land
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

Commit Queue action: https://github.com/nodejs/node/actions/runs/346879770

@Flarna Flarna added fast-track PRs that do not need to wait for 48 hours to land. commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Nov 5, 2020
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 5, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2020

Landed in c822ba7...540b796

@github-actions github-actions bot closed this Nov 5, 2020
nodejs-github-bot pushed a commit that referenced this pull request Nov 5, 2020
@richardlau @nodejs-github-bot
benchmark: remove modules that require intl
540b796 
`inspector` and `trace_events` will throw errors if Node.js has been
compiled with `--without-intl`.

Refs: #35816

PR-URL: #35968
Fixes: #35962
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
@Flarna Flarna mentioned this pull request Nov 5, 2020
Open
14 tasks
@richardlau richardlau deleted the benchmark branch November 5, 2020 09:08
@richardlau richardlau mentioned this pull request Nov 5, 2020
Closed
4 tasks
danielleadams pushed a commit that referenced this pull request Nov 9, 2020
@richardlau @danielleadams
benchmark: remove modules that require intl
4c6de85 
`inspector` and `trace_events` will throw errors if Node.js has been
compiled with `--without-intl`.

Refs: #35816

PR-URL: #35968
Fixes: #35962
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
@danielleadams danielleadams mentioned this pull request Nov 9, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 9, 2020
@richardlau @BethGriggs
benchmark: remove modules that require intl
931bae3 
`inspector` and `trace_events` will throw errors if Node.js has been
compiled with `--without-intl`.

Refs: #35816

PR-URL: #35968
Fixes: #35962
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 10, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
@richardlau @BethGriggs
benchmark: remove modules that require intl
37b7a27 
`inspector` and `trace_events` will throw errors if Node.js has been
compiled with `--without-intl`.

Refs: #35816

PR-URL: #35968
Fixes: #35962
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 10, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
@richardlau @BethGriggs
benchmark: remove modules that require intl
fdb1c0d 
`inspector` and `trace_events` will throw errors if Node.js has been
compiled with `--without-intl`.

Refs: #35816

PR-URL: #35968
Fixes: #35962
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarshithaKP HarshithaKP HarshithaKP approved these changes

@Flarna Flarna Flarna approved these changes

@aduh95 aduh95 aduh95 approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. benchmark Issues and PRs related to the benchmark subsystem. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

investigate flaky benchmark/test-benchmark-misc
7 participants
@richardlau @nodejs-github-bot @lpinca @gireeshpunathil @aduh95 @Flarna @HarshithaKP