Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zlib: test BrotliCompress throws invalid arg value #35830

Closed
wants to merge 1 commit into from
Closed

zlib: test BrotliCompress throws invalid arg value #35830

wants to merge 1 commit into from

Conversation

RaisinTen
Copy link
Contributor

Improving the coverage for this:

node/lib/zlib.js

Lines 807 to 809 in 0ca8617

throw new ERR_INVALID_ARG_TYPE('options.params[key]',
'number', opts.params[origKey]);
}

First time I'm writing a test! 😃

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 27, 2020
@aduh95 aduh95 added the brotli Issues and PRs related to the brotli dependency. label Oct 27, 2020
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 27, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 27, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33888/

@RaisinTen
Copy link
Contributor Author

RaisinTen commented Oct 28, 2020 •
edited
Loading

@lpinca since these commits are all related, do you think I should squash them?

@lpinca
Copy link
Member

lpinca commented Oct 28, 2020

Yes, please do it. Thank you.

@RaisinTen RaisinTen force-pushed the test-zlib-invalid-arg-value-brotlicompress branch from 122b8f1 to a9ce812 Compare October 28, 2020 12:31
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 30, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 30, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@rickyes rickyes added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 31, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 31, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33984/

@lpinca
Copy link
Member

lpinca commented Oct 31, 2020

Landed in c0af8bd.

lpinca pushed a commit that referenced this pull request Oct 31, 2020
@RaisinTen @lpinca
zlib: test BrotliCompress throws invalid arg value
c0af8bd 
PR-URL: #35830
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
@lpinca lpinca closed this Oct 31, 2020
@RaisinTen RaisinTen deleted the test-zlib-invalid-arg-value-brotlicompress branch October 31, 2020 05:49
targos pushed a commit that referenced this pull request Nov 3, 2020
@RaisinTen @targos
zlib: test BrotliCompress throws invalid arg value
102d7df 
PR-URL: #35830
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
@targos targos mentioned this pull request Nov 3, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 8, 2020
@RaisinTen @BethGriggs
zlib: test BrotliCompress throws invalid arg value
0ea3a91 
PR-URL: #35830
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
@RaisinTen @BethGriggs
zlib: test BrotliCompress throws invalid arg value
0d80a93 
PR-URL: #35830
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 10, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
@RaisinTen @BethGriggs
zlib: test BrotliCompress throws invalid arg value
f59e225 
PR-URL: #35830
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
This was referenced May 22, 2023
Open
Open
Open
@137717unity 137717unity mentioned this pull request May 22, 2023
Open
@snyk-bot snyk-bot mentioned this pull request May 23, 2023
Open
@wedataintelligence wedataintelligence mentioned this pull request May 24, 2023
Open
@baby636 baby636 mentioned this pull request May 24, 2023
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Nov 25, 2023
Open
@wedataintelligence wedataintelligence mentioned this pull request Nov 28, 2023
Open
@baby636 baby636 mentioned this pull request Nov 28, 2023
Open
@ron-a20 ron-a20 mentioned this pull request Dec 19, 2023
Open
@137717unity 137717unity mentioned this pull request Dec 19, 2023
Open
@wedataintelligence wedataintelligence mentioned this pull request Dec 19, 2023
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Dec 19, 2023
Open
@baby636 baby636 mentioned this pull request Dec 20, 2023
Open
@137717unity 137717unity mentioned this pull request Apr 14, 2024
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Apr 14, 2024
Open
@ron-a20 ron-a20 mentioned this pull request Apr 14, 2024
Open
@molllyn1 molllyn1 mentioned this pull request Apr 14, 2024
Open
@kissofire kissofire mentioned this pull request Apr 14, 2024
Open
@wedataintelligence wedataintelligence mentioned this pull request Apr 14, 2024
Open
@baby636 baby636 mentioned this pull request Apr 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@rickyes rickyes rickyes approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
brotli Issues and PRs related to the brotli dependency. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@RaisinTen @nodejs-github-bot @lpinca @Trott @rickyes @aduh95