Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: upgrade npm to 7.0.3 #35724

Closed
wants to merge 1 commit into from
Closed

deps: upgrade npm to 7.0.3 #35724

wants to merge 1 commit into from

Conversation

ruyadorno
Copy link
Member

7.0.3 (2020-10-20)

BUG FIXES

DOCUMENTATION

DEPENDENCIES

@nodejs-github-bot nodejs-github-bot added the npm Issues and PRs related to the npm client dependency or the npm registry. label Oct 20, 2020
@codecov-io
Copy link

Codecov Report

Merging #35724 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #35724      +/-   ##
==========================================
- Coverage   96.40%   96.40%   -0.01%     
==========================================
  Files         222      222              
  Lines       73682    73682              
==========================================
- Hits        71034    71033       -1     
- Misses       2648     2649       +1
Impacted Files Coverage Δ
lib/_http_server.js 98.45% <0.00%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b6bbfe...3749ca0. Read the comment docs.

Trott
Trott approved these changes Oct 21, 2020
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM

@MylesBorins MylesBorins added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 21, 2020
@MylesBorins
Copy link
Contributor

Can we get a fast-track so we can perhaps include this in 15.0.1?

@MylesBorins MylesBorins added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 21, 2020
@MylesBorins MylesBorins mentioned this pull request Oct 21, 2020
Merged
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 21, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33783/

@MylesBorins
Copy link
Contributor

Landed in d5088d8

MylesBorins pushed a commit that referenced this pull request Oct 21, 2020
@ruyadorno @MylesBorins
deps: upgrade npm to 7.0.3
d5088d8 
PR-URL: #35724
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@MylesBorins
Copy link
Contributor

FWIW there was as single failure in CI that was unrelated. I pushed the fix since it is time sensitive for 15.0.1

BethGriggs pushed a commit that referenced this pull request Oct 21, 2020
@ruyadorno @BethGriggs
deps: upgrade npm to 7.0.3
595c8df 
PR-URL: #35724
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
BethGriggs added a commit that referenced this pull request Oct 21, 2020
@BethGriggs
2020-10-21, Version 15.0.1 (Current)
0c5dbc1 
Notable changes:

- **crypto**: fix regression on randomFillSync (James M Snell)
  (#35723)
  - This fixes issue #35722.
- **deps**: upgrade npm to 7.0.3 (Ruy Adorno)
  (#35724)
- **doc**: add release key for Danielle Adams (Danielle Adams)
  (#35545)

PR-URL: #35736
BethGriggs added a commit that referenced this pull request Oct 21, 2020
@BethGriggs
2020-10-21, Version 15.0.1 (Current)
8451c4a 
Notable changes:

- **crypto**: fix regression on randomFillSync (James M Snell)
  (#35723)
  - This fixes issue #35722.
- **deps**: upgrade npm to 7.0.3 (Ruy Adorno)
  (#35724)
- **doc**: add release key for Danielle Adams (Danielle Adams)
  (#35545)

PR-URL: #35736
BethGriggs added a commit that referenced this pull request Oct 21, 2020
@BethGriggs
2020-10-21, Version 15.0.1 (Current)
4d16554 
Notable changes:

- **crypto**: fix regression on randomFillSync (James M Snell)
  (#35723)
  - This fixes issue #35722.
- **deps**: upgrade npm to 7.0.3 (Ruy Adorno)
  (#35724)
- **doc**: add release key for Danielle Adams (Danielle Adams)
  (#35545)

PR-URL: #35736
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@watilde watilde watilde approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ruyadorno @codecov-io @MylesBorins @nodejs-github-bot @Trott @watilde @BethGriggs