test: use port number from env in tls socket test #3557
Conversation
Tests normally use common.PORT to allow the user to select which port number to listen on. Hardcoding the port number will cause parallel instances of the test to fail.
|
LGTM if CI is happy. /cc @indutny |
|
LGTM, if CI is green |
|
pretty sure this can't live in parallel any more with it changed to |
|
@rvagg |
|
@Trott Thanks for the clarification. I should have used more precise language in my comment. The issue I have is with running multiple instances of the test harness in parallel (perhaps "concurrent" would have been a better term). To avoid collisions I'm using a distinct NODE_COMMON_PORT value for each instance, but this particular test does not respect the environment value, causing grief. The intent of the PR is to resolve socket errors in this admittedly peculiar, but annoying scenario. |
mscdex
added
tls
|
We don't run tests in parallel in CI anyway. The change LGTM. |
Tests normally use common.PORT to allow the user to select which port number to listen on. Hardcoding the port number will cause parallel instances of the test to fail. PR-URL: #3557 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
|
Landed in c9e682d, thanks. |
|
@jbergstroem Oh, right, not on CI but on local machines when people use |
Tests normally use common.PORT to allow the user to select which port number to listen on. Hardcoding the port number will cause parallel instances of the test to fail. PR-URL: nodejs#3557 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
Tests normally use common.PORT to allow the user to select which port number to listen on. Hardcoding the port number will cause parallel instances of the test to fail. PR-URL: #3557 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
Tests normally use common.PORT to allow the user to select which port number to listen on. Hardcoding the port number will cause parallel instances of the test to fail. PR-URL: #3557 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
|
Landed in v4.x-staging in 295c964 |
Tests normally use common.PORT to allow the user to select which port
number to listen on. Hardcoding the port number will cause parallel
instances of the test to fail.