Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub Actions: Python 3.9 and actions/setup-python@v2 #35521

Closed
wants to merge 2 commits into from
Closed

GitHub Actions: Python 3.9 and actions/setup-python@v2 #35521

wants to merge 2 commits into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Oct 6, 2020 •
edited
Loading

GitHub Actions: Upgrade to Python 3.9 and actions/setup-python@v2

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@cclauss cclauss added test Issues and PRs related to the tests. python PRs and issues that require attention from people who are familiar with Python. labels Oct 6, 2020
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 6, 2020
@richardlau
Copy link
Member

ugh looks like we'll also need to add Python 3.9 to configure/build scripts.

@Trott
Copy link
Member

Trott commented Oct 6, 2020

Is this fast-trackable?

@cclauss
Copy link
Contributor Author

cclauss commented Oct 6, 2020 •
edited
Loading

It is in my book.

I think we should follow up in a few days with a docs change officially supporting Python 3.9 and perhaps with the removal of support with Python 3.5 which is now end-of-life.

MylesBorins
MylesBorins approved these changes Oct 7, 2020
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gengjiawen gengjiawen added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 8, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 8, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33473/

@codebytere codebytere added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 8, 2020
gengjiawen pushed a commit that referenced this pull request Oct 9, 2020
@cclauss @gengjiawen
build: gitHub actions: Python 3.9 and actions/setup-python@v2
c8b950a 
PR-URL: #35521
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
@gengjiawen
Copy link
Member

Landed in c8b950a

@gengjiawen gengjiawen closed this Oct 9, 2020
@cclauss cclauss deleted the GitHub_Actions_Python3.9 branch October 9, 2020 06:10
MylesBorins pushed a commit that referenced this pull request Oct 14, 2020
@cclauss @MylesBorins
build: gitHub actions: Python 3.9 and actions/setup-python@v2
b730528 
PR-URL: #35521
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Oct 14, 2020
Merged
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@cclauss @joesepi
build: gitHub actions: Python 3.9 and actions/setup-python@v2
0741a84 
PR-URL: nodejs#35521
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 13, 2021
@cclauss @Trott
build: gitHub actions: Python 3.9 and actions/setup-python@v2
5f7b16a 
PR-URL: nodejs#35521
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 13, 2021
@cclauss @Trott
build: gitHub actions: Python 3.9 and actions/setup-python@v2
043778e 
PR-URL: nodejs#35521
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 13, 2021
@cclauss @Trott
build: gitHub actions: Python 3.9 and actions/setup-python@v2
d420e07 
PR-URL: nodejs#35521
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 13, 2021
@cclauss @Trott
build: gitHub actions: Python 3.9 and actions/setup-python@v2
c83dcdb 
PR-URL: nodejs#35521
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 14, 2021
@cclauss @Trott
build: gitHub actions: Python 3.9 and actions/setup-python@v2
9b9f2a9 
PR-URL: nodejs#35521
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 14, 2021
@cclauss @Trott
build: gitHub actions: Python 3.9 and actions/setup-python@v2
295c7b9 
PR-URL: nodejs#35521
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 14, 2021
@cclauss @Trott
build: gitHub actions: Python 3.9 and actions/setup-python@v2
c7c07a9 
PR-URL: nodejs#35521
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 14, 2021
@cclauss @Trott
build: gitHub actions: Python 3.9 and actions/setup-python@v2
4ca1991 
PR-URL: nodejs#35521
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 14, 2021
@cclauss @Trott
build: gitHub actions: Python 3.9 and actions/setup-python@v2
1c68cc1 
PR-URL: nodejs#35521
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 14, 2021
@cclauss @Trott
build: gitHub actions: Python 3.9 and actions/setup-python@v2
1eccb43 
PR-URL: nodejs#35521
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 14, 2021
@cclauss @Trott
build: gitHub actions: Python 3.9 and actions/setup-python@v2
55637ea 
PR-URL: nodejs#35521
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 14, 2021
@cclauss @Trott
build: gitHub actions: Python 3.9 and actions/setup-python@v2
a2223ef 
PR-URL: nodejs#35521
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 14, 2021
@cclauss @Trott
build: gitHub actions: Python 3.9 and actions/setup-python@v2
d86ddd1 
PR-URL: nodejs#35521
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 14, 2021
@cclauss @Trott
build: gitHub actions: Python 3.9 and actions/setup-python@v2
bff44ce 
PR-URL: nodejs#35521
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 14, 2021
@cclauss @Trott
build: gitHub actions: Python 3.9 and actions/setup-python@v2
cd58232 
PR-URL: nodejs#35521
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 14, 2021
@cclauss @Trott
build: gitHub actions: Python 3.9 and actions/setup-python@v2
1bf7527 
PR-URL: nodejs#35521
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 14, 2021
@cclauss @Trott
build: gitHub actions: Python 3.9 and actions/setup-python@v2
66f5acc 
PR-URL: nodejs#35521
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 14, 2021
@cclauss @Trott
build: gitHub actions: Python 3.9 and actions/setup-python@v2
53f6c4c 
PR-URL: nodejs#35521
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 14, 2021
@cclauss @Trott
build: gitHub actions: Python 3.9 and actions/setup-python@v2
9b7d94b 
PR-URL: nodejs#35521
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 14, 2021
@cclauss @Trott
build: gitHub actions: Python 3.9 and actions/setup-python@v2
eec6857 
PR-URL: nodejs#35521
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 15, 2021
@cclauss @Trott
build: gitHub actions: Python 3.9 and actions/setup-python@v2
c439c4c 
PR-URL: nodejs#35521
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 15, 2021
@cclauss @Trott
build: gitHub actions: Python 3.9 and actions/setup-python@v2
716144c 
PR-URL: nodejs#35521
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 15, 2021
@cclauss @Trott
build: gitHub actions: Python 3.9 and actions/setup-python@v2
2ed660f 
PR-URL: nodejs#35521
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 15, 2021
@cclauss @Trott
build: gitHub actions: Python 3.9 and actions/setup-python@v2
2c68eff 
PR-URL: nodejs#35521
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 15, 2021
@cclauss @Trott
build: gitHub actions: Python 3.9 and actions/setup-python@v2
6b0165b 
PR-URL: nodejs#35521
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 15, 2021
@cclauss @Trott
build: gitHub actions: Python 3.9 and actions/setup-python@v2
9f345f8 
PR-URL: nodejs#35521
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 15, 2021
@cclauss @Trott
build: gitHub actions: Python 3.9 and actions/setup-python@v2
aded665 
PR-URL: nodejs#35521
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 16, 2021
@cclauss @Trott
build: gitHub actions: Python 3.9 and actions/setup-python@v2
e7470d2 
PR-URL: nodejs#35521
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 16, 2021
@cclauss @Trott
build: gitHub actions: Python 3.9 and actions/setup-python@v2
ca73afb 
PR-URL: nodejs#35521
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 16, 2021
@cclauss @Trott
build: gitHub actions: Python 3.9 and actions/setup-python@v2
c09ef48 
PR-URL: nodejs#35521
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 16, 2021
@cclauss @Trott
build: gitHub actions: Python 3.9 and actions/setup-python@v2
c2d819f 
PR-URL: nodejs#35521
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@codebytere codebytere codebytere approved these changes

@Trott Trott Trott approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

@mmarchini mmarchini Awaiting requested review from mmarchini

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. meta Issues and PRs related to the general management of the project. python PRs and issues that require attention from people who are familiar with Python. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cclauss @richardlau @Trott @nodejs-github-bot @gengjiawen @MylesBorins @codebytere