doc: use present tense in error messages #35164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
addaleax
approved these changes
Sep 12, 2020
lundibundi
approved these changes
Sep 13, 2020
lundibundi
added
the
author ready
DerekNonGeneric
approved these changes
Sep 13, 2020
lpinca
approved these changes
Sep 13, 2020
|
Landed in 9d12c14 |
Error messages are a mix of present and past tense. They should be mostly or entirely present tense. This eliminates the past tense constructions "was found" and "were found". PR-URL: nodejs#35164 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
|
hi @Trott this doesn't land cleanly on v14.x, can someone backport it? 😊 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Sep 18, 2020
Error messages are a mix of present and past tense. They should be mostly or entirely present tense. This eliminates the past tense constructions "was found" and "were found". PR-URL: nodejs#35164 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
2 tasks
@ruyadorno Backport at #35247 |
ruyadorno
pushed a commit
that referenced
this pull request
Sep 22, 2020
Error messages are a mix of present and past tense. They should be mostly or entirely present tense. This eliminates the past tense constructions "was found" and "were found". Backport-PR-URL: #35247 PR-URL: #35164 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
Error messages are a mix of present and past tense. They should be mostly or entirely present tense. This eliminates the past tense constructions "was found" and "were found". PR-URL: nodejs#35164 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error messages are a mix of present and past tense. They should be
mostly or entirely present tense. This eliminates the past tense
constructions "was found" and "were found".
Checklist